Implemented remaining non-grouped longhand property APIs

third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/css/properties/CSSPropertyAPIGridGap.h"
+
+namespace blink {
+
+class CSSParserContext;
+class CSSParserLocalContext;
+class CSSParserTokenRange;
+class CSSValue;
+
+const CSSValue* CSSPropertyAPIGridGap::parseSingleValue(

[Jia, 2017/06/08 22:07:14]

This is a shorthand, it should impl parseShorthand.

+    CSSParserTokenRange& range,
+    const CSSParserContext& context,
+    const CSSParserLocalContext&) {
+  DCHECK(RuntimeEnabledFeatures::CSSGridLayoutEnabled());
+  DCHECK_EQ(shorthandForProperty(CSSPropertyGridGap).length(), 2u);
+  CSSValue* row_gap = ConsumeLengthOrPercent(range, context->Mode(),
+                                             kValueRangeNonNegative);
+  CSSValue* column_gap = ConsumeLengthOrPercent(range, context->Mode(),
+                                                kValueRangeNonNegative);
+  if (!row_gap || !range.AtEnd())
+    return false;
+  if (!column_gap)
+    column_gap = row_gap;
+  AddParsedProperty(CSSPropertyGridRowGap, CSSPropertyGridGap, *row_gap,
+                    important);

[Jia, 2017/06/08 22:07:14]

AddParsedProperty is a wrapper function private to CSSPropertyParser. I don't
think the code would compile.

[Bugs Nash, 2017/06/09 00:00:17]

no this code certainly doesn't compile! as I mentioned before, this is an FYI
for a WIP. many compile errors like this need to be fixed yet (mostly #includes
and CSPropertyParserHelpers prefixes)

[Jia, 2017/06/09 00:10:07]

Ok, so I don't need to lgtm for now. Thanks for the headsup!

+  AddParsedProperty(CSSPropertyGridColumnGap, CSSPropertyGridGap,
+                    *column_gap, important);
+  return true;
+}
+}
+
+}  // namespace blink