Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2882563002: Revert of include Package proto into Result proto (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
Reviewers:
nodir, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of include Package proto into Result proto (patchset #3 id:40001 of https://codereview.chromium.org/2802693003/ ) Reason for revert: broke the world: https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-32/builds/7475/steps/steps/logs/stdio Original issue's description: > include Package proto into Result proto > > Kitchen runs recipes using recipe engine and needs to know revisions of > recipe dependencies that were used for a run. > > Export entire contents of recipes.cfg in the new result proto. > > R=iannucci@chromium.org, martiniss@chromium.org > BUG=695485 > > Review-Url: https://codereview.chromium.org/2802693003 > Committed: https://github.com/luci/recipes-py/commit/c7d91ef9861b04e41c6a2381382efd58d111fe19 TBR=martiniss@chromium.org,nodir@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695485 Review-Url: https://codereview.chromium.org/2882563002 Committed: https://github.com/luci/recipes-py/commit/b7c18e0258998652eeb302c83680f6a2b1aee398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -62 lines) Patch
M recipe_engine/loader.py View 2 chunks +1 line, -1 line 0 comments Download
M recipe_engine/package.py View 2 chunks +1 line, -2 lines 0 comments Download
M recipe_engine/result.proto View 2 chunks +0 lines, -5 lines 0 comments Download
M recipe_engine/result_pb2.py View 8 chunks +30 lines, -40 lines 0 comments Download
M recipe_engine/run.py View 2 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
iannucci
Created Revert of include Package proto into Result proto
3 years, 7 months ago (2017-05-12 00:43:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882563002/1
3 years, 7 months ago (2017-05-12 00:43:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/recipes-py/commit/b7c18e0258998652eeb302c83680f6a2b1aee398
3 years, 7 months ago (2017-05-12 00:43:53 UTC) #6
iannucci
3 years, 7 months ago (2017-05-12 00:45:00 UTC) #7
Message was sent while issue was closed.
relevant error:

kitchen_error: <
  text: "could not parse recipe result: unknown field \"recipePackage\" in
recipe_engine.Result"
  call_stack: "original error: unknown field \"recipePackage\" in
recipe_engine.Result"
  call_stack: ""
  call_stack: "goroutine 1:"
  call_stack: "#0 kitchen/cook.go:382 - main.(*cookRun).ensureAndRunRecipe()"
  call_stack: "  reason: \"could not parse recipe result\""
  call_stack: ""
  call_stack: "#1 kitchen/cook.go:619 - main.(*cookRun).run()"
  call_stack: "#2 kitchen/cook.go:519 - main.(*cookRun).Run()"
  call_stack: "#3 github.com/maruel/subcommands/subcommands.go:360 -
subcommands.Run()"
  call_stack: "#4 kitchen/kitchen.go:52 - main.main()"
  call_stack: "#5 runtime/proc.go:185 - runtime.main()"
  call_stack: "#6 runtime/asm_386.s:1629 - runtime.goexit()"
>

Powered by Google App Engine
This is Rietveld 408576698