Implement Ukm Mojo interface.

Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/

TBR=holte

Review-Url: https://codereview.chromium.org/2882353002
Cr-Commit-Position: refs/heads/master@{#475658}
Committed: https://chromium.googlesource.com/chromium/src/+/c0934409a5ad0453174431362d47fff9e6e68e13

[Steven Holte, 2017-05-15 23:18:13]

holte@chromium.org changed reviewers:
+ oysteine@chromium.org

[Steven Holte, 2017-05-15 23:18:13]

Extracted from https://codereview.chromium.org/2883563002/

[oystein (OOO til 10th of July), 2017-05-17 01:16:19]

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/public/m...
File components/ukm/public/mojo_ukm_recorder.cc (right):

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/public/m...
components/ukm/public/mojo_ukm_recorder.cc:12: :
interface_(std::move(interface)){};
nit: space before {}

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
File components/ukm/ukm_interface.h (right):

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
components/ukm/ukm_interface.h:8: #include
"components/ukm/public/interfaces/ukm_interface.mojom.h"
We're missing ukm_interface.mojom from this CL, I guess?

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
components/ukm/ukm_interface.h:28: // rappor::mojom::UkmRecorderInterface:
s/rappor/ukm/

[oystein (OOO til 10th of July), 2017-05-17 01:19:15]

On 2017/05/17 at 01:16:19, oystein wrote:
>
https://codereview.chromium.org/2882353002/diff/20001/components/ukm/public/m...
> File components/ukm/public/mojo_ukm_recorder.cc (right):
> 
>
https://codereview.chromium.org/2882353002/diff/20001/components/ukm/public/m...
> components/ukm/public/mojo_ukm_recorder.cc:12: :
interface_(std::move(interface)){};
> nit: space before {}
> 
>
https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
> File components/ukm/ukm_interface.h (right):
> 
>
https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
> components/ukm/ukm_interface.h:8: #include
"components/ukm/public/interfaces/ukm_interface.mojom.h"
> We're missing ukm_interface.mojom from this CL, I guess?
> 
>
https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
> components/ukm/ukm_interface.h:28: // rappor::mojom::UkmRecorderInterface:
> s/rappor/ukm/

(lgtm other than those nits; I assume the .mojom is the same as in the linked CL
:) )

[Steven Holte, 2017-05-17 17:40:17]

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/public/m...
File components/ukm/public/mojo_ukm_recorder.cc (right):

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/public/m...
components/ukm/public/mojo_ukm_recorder.cc:12: :
interface_(std::move(interface)){};
On 2017/05/17 01:16:18, oystein wrote:
> nit: space before {}

Done.

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
File components/ukm/ukm_interface.h (right):

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
components/ukm/ukm_interface.h:8: #include
"components/ukm/public/interfaces/ukm_interface.mojom.h"
On 2017/05/17 01:16:18, oystein wrote:
> We're missing ukm_interface.mojom from this CL, I guess?

This one is dependent on the other CL.

https://codereview.chromium.org/2882353002/diff/20001/components/ukm/ukm_inte...
components/ukm/ukm_interface.h:28: // rappor::mojom::UkmRecorderInterface:
On 2017/05/17 01:16:18, oystein wrote:
> s/rappor/ukm/

Done.

[Steven Holte, 2017-05-17 17:43:01]

Description was changed from

==========
Implement Ukm Mojo interface.

BUG=
==========

to

==========
Implement Ukm Mojo interface.

Depends on https://codereview.chromium.org/2883563002/


BUG=
==========

[Steven Holte, 2017-05-17 17:51:52]

holte@chromium.org changed reviewers:
+ yzshen@chromium.org

[Steven Holte, 2017-05-17 17:51:52]

+yzshen for DEP on mojo/public from components/ukm

Note the follow up to actually expose the interface is in this CL:
https://codereview.chromium.org/2882353002/

[Steven Holte, 2017-05-17 17:54:33]

On 2017/05/17 17:51:52, Steven Holte wrote:
> +yzshen for DEP on mojo/public from components/ukm
> 
> Note the follow up to actually expose the interface is in this CL:
> https://codereview.chromium.org/2882353002/

Sorry, wrong CL.  This one is the follow up, the base one is
https://codereview.chromium.org/2883563002/

[oystein (OOO til 10th of July), 2017-05-24 17:22:42]

On 2017/05/17 at 17:54:33, holte wrote:
> On 2017/05/17 17:51:52, Steven Holte wrote:
> > +yzshen for DEP on mojo/public from components/ukm
> > 
> > Note the follow up to actually expose the interface is in this CL:
> > https://codereview.chromium.org/2882353002/
> 
> Sorry, wrong CL.  This one is the follow up, the base one is
https://codereview.chromium.org/2883563002/

yzshen: gentle ping :)

[oystein (OOO til 10th of July), 2017-05-24 17:23:25]

On 2017/05/24 at 17:22:42, oystein wrote:
> On 2017/05/17 at 17:54:33, holte wrote:
> > On 2017/05/17 17:51:52, Steven Holte wrote:
> > > +yzshen for DEP on mojo/public from components/ukm
> > > 
> > > Note the follow up to actually expose the interface is in this CL:
> > > https://codereview.chromium.org/2882353002/
> > 
> > Sorry, wrong CL.  This one is the follow up, the base one is
https://codereview.chromium.org/2883563002/
> 
> yzshen: gentle ping :)

(I'm taking over landing this CL since holte@ is OOO, will create a new once for
changes needed + landing it).

[yzshen1, 2017-05-24 19:43:07]

On 2017/05/24 17:22:42, oystein wrote:
> On 2017/05/17 at 17:54:33, holte wrote:
> > On 2017/05/17 17:51:52, Steven Holte wrote:
> > > +yzshen for DEP on mojo/public from components/ukm
> > > 
> > > Note the follow up to actually expose the interface is in this CL:
> > > https://codereview.chromium.org/2882353002/
> > 
> > Sorry, wrong CL.  This one is the follow up, the base one is
> https://codereview.chromium.org/2883563002/
> 
> yzshen: gentle ping :)

I am very sorry for missing this. I thought you would like me to LG the base
one, which I did.

(Btw, if you find that I haven't replied to a code review for more than a day,
please feel free to ping me using IM. Likely I missed the notification email.)

[oystein (OOO til 10th of July), 2017-05-24 20:41:39]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 20:42:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oystein (OOO til 10th of July), 2017-05-24 21:17:22]

Description was changed from

==========
Implement Ukm Mojo interface.

Depends on https://codereview.chromium.org/2883563002/


BUG=
==========

to

==========
Implement Ukm Mojo interface.

Depends on https://codereview.chromium.org/2883563002/
==========

[oystein (OOO til 10th of July), 2017-05-24 21:17:22]

oysteine@chromium.org changed reviewers:
+ nasko@chromium.org

[oystein (OOO til 10th of July), 2017-05-24 21:17:41]

+nasko for content/renderer

[oystein (OOO til 10th of July), 2017-05-24 21:18:42]

On 2017/05/24 at 21:17:41, oystein wrote:
> +nasko for content/renderer

Oh and also nasko for the manifest change. ptal!

[oystein (OOO til 10th of July), 2017-05-24 21:21:45]

Description was changed from

==========
Implement Ukm Mojo interface.

Depends on https://codereview.chromium.org/2883563002/
==========

to

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/


BUG=
==========

[oystein (OOO til 10th of July), 2017-05-24 21:21:45]

oysteine@chromium.org changed reviewers:
- nasko@chromium.org

[oystein (OOO til 10th of July), 2017-05-24 21:21:51]

Description was changed from

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/


BUG=
==========

to

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/
==========

[commit-bot: I haz the power, 2017-05-24 23:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:25:17]

Dry run: This issue passed the CQ dry run.

[oystein (OOO til 10th of July), 2017-05-25 21:24:11]

oysteine@chromium.org changed reviewers:
+ nasko@chromium.org

[oystein (OOO til 10th of July), 2017-05-25 21:24:35]

On 2017/05/24 at 21:18:42, oystein wrote:
> On 2017/05/24 at 21:17:41, oystein wrote:
> > +nasko for content/renderer
> 
> Oh and also nasko for the manifest change. ptal!

Whoops, didn't actually edit the reviewer list it seems.

+nasko for content/renderer and manifest change. Thanks!

[oystein (OOO til 10th of July), 2017-05-25 21:25:08]

Description was changed from

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/
==========

to

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/

TBR=holte
==========

[oystein (OOO til 10th of July), 2017-05-25 21:25:08]

oysteine@chromium.org changed reviewers:
+ holte@chromium.org

[oystein (OOO til 10th of July), 2017-05-25 22:18:21]

oysteine@chromium.org changed reviewers:
- yzshen@chromium.org

[oystein (OOO til 10th of July), 2017-05-26 22:07:09]

oysteine@chromium.org changed reviewers:
+ creis@chromium.org, tsepez@chromium.org
- nasko@chromium.org

[oystein (OOO til 10th of July), 2017-05-26 22:08:14]

nasko's going ooo, so:

+tsepez for manifest and Mojo-ness
+creis for content/renderer/DEPS

[Tom Sepez, 2017-05-30 17:13:59]

lgtm

[oystein (OOO til 10th of July), 2017-05-30 17:25:22]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2017-05-30 17:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
oysteine@chromium.org
Link to the patchset: https://codereview.chromium.org/2882353002/#ps40001
(title: "Fix nits")

[oystein (OOO til 10th of July), 2017-05-30 17:25:32]

The CQ bit was unchecked by oysteine@chromium.org

[Charlie Reis, 2017-05-30 18:08:53]

RS LGTM for content/

[oystein (OOO til 10th of July), 2017-05-30 18:38:37]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:39:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:42:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496169517098190,
"parent_rev": "5828a72d5f5d969ce71280572604f3439123c524", "commit_rev":
"c0934409a5ad0453174431362d47fff9e6e68e13"}

[commit-bot: I haz the power, 2017-05-30 20:43:07]

Description was changed from

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/

TBR=holte
==========

to

==========
Implement Ukm Mojo interface and make it available to content/renderer

Depends on https://codereview.chromium.org/2883563002/

TBR=holte

Review-Url: https://codereview.chromium.org/2882353002
Cr-Commit-Position: refs/heads/master@{#475658}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0934409a5ad0453174431362d47...
==========

[commit-bot: I haz the power, 2017-05-30 20:43:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c0934409a5ad0453174431362d47...