|
Refactor UKM interface for mojo-ification
* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
- Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/
TBR=sebsg,yzshen1,sky,groby
BUG=
Total comments: 26
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1177 lines, -1169 lines) |
Patch |
|
M |
android_webview/browser/aw_autofill_client.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
android_webview/browser/aw_autofill_client.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/android/metrics/uma_session_stats.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser_process.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser_process_impl.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/browser_process_impl.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/metrics/chrome_metrics_service_client.cc
|
View
|
1
|
2 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
|
View
|
|
6 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
|
View
|
1
|
8 chunks |
+98 lines, -130 lines |
0 comments
|
Download
|
|
M |
chrome/browser/payments/chrome_payment_request_delegate.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/payments/chrome_payment_request_delegate.cc
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/plugins/plugin_info_message_filter.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/plugins/plugin_info_message_filter.cc
|
View
|
|
4 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_ranker_factory.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/autofill/chrome_autofill_client.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/autofill/chrome_autofill_client.cc
|
View
|
1
2
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/testing_browser_process.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/testing_browser_process.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_client.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_manager.cc
|
View
|
1
2
3
4
|
5 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_manager_unittest.cc
|
View
|
1
2
3
4
|
9 chunks |
+28 lines, -46 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_metrics.h
|
View
|
1
2
3
4
|
4 chunks |
+8 lines, -7 lines |
2 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_metrics.cc
|
View
|
1
2
3
4
|
13 chunks |
+36 lines, -29 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_metrics_unittest.cc
|
View
|
1
2
3
4
|
45 chunks |
+144 lines, -171 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/form_structure.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/form_structure.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/test_autofill_client.h
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/test_autofill_client.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/metrics/proto/ukm/entry.proto
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/metrics/proto/ukm/source.proto
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/payments/content/payment_request.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/payments/core/autofill_payment_instrument_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/payments/core/journey_logger.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/payments/core/journey_logger.cc
|
View
|
1
2
3
4
|
3 chunks |
+10 lines, -9 lines |
0 comments
|
Download
|
|
M |
components/payments/core/journey_logger_unittest.cc
|
View
|
|
25 chunks |
+39 lines, -60 lines |
0 comments
|
Download
|
|
M |
components/payments/core/payment_request_delegate.h
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/payments/core/test_payment_request_delegate.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/payments/core/test_payment_request_delegate.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/translate/core/browser/translate_ranker_impl.h
|
View
|
1
2
3
4
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/translate/core/browser/translate_ranker_impl.cc
|
View
|
1
2
3
4
|
3 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
components/translate/core/browser/translate_ranker_impl_unittest.cc
|
View
|
1
2
3
4
|
5 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
M |
components/ukm/BUILD.gn
|
View
|
1
2
|
3 chunks |
+10 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/ukm/DEPS
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/ukm/debug_page/debug_page.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/BUILD.gn
|
View
|
2
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/interfaces/BUILD.gn
|
View
|
|
1 chunk |
+15 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/interfaces/OWNERS
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/interfaces/ukm_interface.mojom
|
View
|
1
2
3
4
5
|
1 chunk |
+22 lines, -0 lines |
0 comments
|
Download
|
|
A + |
components/ukm/public/ukm_entry_builder.h
|
View
|
|
2 chunks |
+12 lines, -15 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/ukm_entry_builder.cc
|
View
|
|
1 chunk |
+32 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/ukm_recorder.h
|
View
|
1
2
3
|
1 chunk |
+97 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/public/ukm_recorder.cc
|
View
|
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/test_ukm_recorder.h
|
View
|
1
2
3
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/test_ukm_recorder.cc
|
View
|
1
2
3
|
1 chunk |
+67 lines, -0 lines |
0 comments
|
Download
|
|
D |
components/ukm/test_ukm_service.h
|
View
|
|
1 chunk |
+0 lines, -57 lines |
0 comments
|
Download
|
|
D |
components/ukm/test_ukm_service.cc
|
View
|
|
1 chunk |
+0 lines, -73 lines |
0 comments
|
Download
|
|
D |
components/ukm/ukm_entry.h
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
|
D |
components/ukm/ukm_entry.cc
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
|
D |
components/ukm/ukm_entry_builder.h
|
View
|
|
1 chunk |
+0 lines, -54 lines |
0 comments
|
Download
|
|
D |
components/ukm/ukm_entry_builder.cc
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
|
A |
components/ukm/ukm_recorder_impl.h
|
View
|
1
2
3
|
1 chunk |
+72 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/ukm/ukm_recorder_impl.cc
|
View
|
1
2
3
|
1 chunk |
+175 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/ukm/ukm_service.h
|
View
|
1
|
6 chunks |
+3 lines, -81 lines |
0 comments
|
Download
|
|
M |
components/ukm/ukm_service.cc
|
View
|
|
8 chunks |
+3 lines, -158 lines |
0 comments
|
Download
|
|
M |
components/ukm/ukm_service_unittest.cc
|
View
|
|
18 chunks |
+68 lines, -38 lines |
0 comments
|
Download
|
|
M |
components/ukm/ukm_source.h
|
View
|
|
2 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/application_context.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/application_context_impl.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ios/chrome/browser/application_context_impl.cc
|
View
|
1
2
3
4
5
6
7
8
|
4 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/translate/translate_ranker_factory.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/autofill/autofill_client_ios.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/autofill/autofill_client_ios.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
ios/chrome/test/testing_application_context.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ios/chrome/test/testing_application_context.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 45 (32 generated)
|