Block insecure pepper media requests in the renderer

Block insecure pepper media requests in the renderer

This adds a feature flag which (when enabled) blocks pepper plugin media
(camera and mic) requests from insecure origins. A console message is logged
in those cases. 

These checks happen in the renderer, but checks will also be added to the 
browser in a followup.

BUG=526324
Review-Url: https://codereview.chromium.org/2882133002
Cr-Commit-Position: refs/heads/master@{#472299}
Committed: https://chromium.googlesource.com/chromium/src/+/517cdca479804e38de1a433bf08e41c3bf567698

[raymes, 2017-05-15 00:55:24]

Description was changed from

==========
Block insecure pepper media requests

This adds a feature flag which (when enabled) blocks pepper plugin media
(camera and mic) requests from insecure origins. A console message is
logged
in those cases. Tests are added for this scenario.

Note that we don't actually check the origin of the plugin, as the
security
check is based on the origin of the embedding document. We check the
origin of
the embedding document and the top level origin. In conjunction with the
mixed
content requirement this ensures that the entire chain of embedders, as
well as
the swf itself must be served from a secure origin in order for the
plugin to
use camera/mic. We should actually check the entire chain of embedders
here
including the requesting swf but the plumbing does not currently exist
to do
that.

BUG=526324
==========

to

==========
Block insecure pepper media requests in the renderer

This adds a feature flag which (when enabled) blocks pepper plugin media
(camera and mic) requests from insecure origins. A console message is logged
in those cases. 

These checks happen in the renderer, but checks will also be added to the 
browser in a followup.

BUG=526324
==========

[raymes, 2017-05-15 01:52:02]

raymes@chromium.org changed reviewers:
+ bbudge@chromium.org

[raymes, 2017-05-15 01:52:03]

bbudge: could you ptal? None of the code here is tested so it's difficult to add
tests. I've tested this manually and I will add tests to the browser-side checks
in: https://codereview.chromium.org/2880503002/ 

Does that seem ok to you?

[raymes, 2017-05-15 02:42:44]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 02:42:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 03:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 03:31:21]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-05-16 01:30:04]

raymes@chromium.org changed reviewers:
+ alexmos@chromium.org

[raymes, 2017-05-16 01:30:05]

+alexmos for content/

[raymes, 2017-05-16 01:30:42]

On 2017/05/16 01:30:05, raymes wrote:
> +alexmos for content/

Sorry - specifically for content/public/common/content_features.h

bbudge and I are OWNERS for content/renderer/pepper

[alexmos, 2017-05-16 04:27:00]

content/public/common LGTM

[bbudge, 2017-05-16 18:20:46]

On 2017/05/15 01:52:03, raymes wrote:
> bbudge: could you ptal? None of the code here is tested so it's difficult to
add
> tests. I've tested this manually and I will add tests to the browser-side
checks
> in: https://codereview.chromium.org/2880503002/ 
> 
> Does that seem ok to you?

It looks straightforward so lgtm

[raymes, 2017-05-16 22:25:45]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:27:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:17:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2017-05-16 23:30:55]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:33:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:05:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494977455437360,
"parent_rev": "d9a57a28176f2278ef0f62bb1bd53e7e0e5aab9a", "commit_rev":
"517cdca479804e38de1a433bf08e41c3bf567698"}

[commit-bot: I haz the power, 2017-05-17 03:05:42]

Description was changed from

==========
Block insecure pepper media requests in the renderer

This adds a feature flag which (when enabled) blocks pepper plugin media
(camera and mic) requests from insecure origins. A console message is logged
in those cases. 

These checks happen in the renderer, but checks will also be added to the 
browser in a followup.

BUG=526324
==========

to

==========
Block insecure pepper media requests in the renderer

This adds a feature flag which (when enabled) blocks pepper plugin media
(camera and mic) requests from insecure origins. A console message is logged
in those cases. 

These checks happen in the renderer, but checks will also be added to the 
browser in a followup.

BUG=526324

Review-Url: https://codereview.chromium.org/2882133002
Cr-Commit-Position: refs/heads/master@{#472299}
Committed:
https://chromium.googlesource.com/chromium/src/+/517cdca479804e38de1a433bf08e...
==========

[commit-bot: I haz the power, 2017-05-17 03:05:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/517cdca479804e38de1a433bf08e...