Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2880503002: Block insecure pepper requests (Closed)

Created:
3 years, 7 months ago by raymes
Modified:
3 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, raymes+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-permissions_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Block insecure pepper media requests This adds a feature flag which (when enabled) blocks pepper plugin media (camera and mic) requests from insecure origins in the browser. This is already checked in the renderer here: https://codereview.chromium.org/2882133002/. Note that the secure origin check in the browser doesn't exactly correspond to the secure context check in the renderer. We should make these match at some point. BUG=526324 Review-Url: https://codereview.chromium.org/2880503002 Cr-Commit-Position: refs/heads/master@{#473487} Committed: https://chromium.googlesource.com/chromium/src/+/be827b4b23c8e28143f175ebb4d219065e72a607

Patch Set 1 #

Patch Set 2 : Block insecure pepper requests #

Patch Set 3 : Block insecure pepper requests #

Patch Set 4 : Block insecure pepper requests #

Patch Set 5 : Block insecure pepper requests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M chrome/browser/media/webrtc/media_stream_device_permission_context.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc View 1 2 3 4 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc View 1 2 3 3 chunks +25 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (16 generated)
raymes
3 years, 7 months ago (2017-05-11 03:42:27 UTC) #3
raymes
ptal
3 years, 7 months ago (2017-05-15 02:43:20 UTC) #9
Timothy Loh
On 2017/05/15 02:43:20, raymes wrote: > ptal lgtm
3 years, 7 months ago (2017-05-15 06:58:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880503002/80001
3 years, 7 months ago (2017-05-17 05:04:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/455729)
3 years, 7 months ago (2017-05-17 06:43:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880503002/80001
3 years, 7 months ago (2017-05-17 22:01:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880503002/80001
3 years, 7 months ago (2017-05-18 02:20:14 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448253)
3 years, 7 months ago (2017-05-18 07:02:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880503002/80001
3 years, 7 months ago (2017-05-21 22:19:53 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 23:03:03 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/be827b4b23c8e28143f175ebb4d2...

Powered by Google App Engine
This is Rietveld 408576698