[DevTools] Support async step in from arbitrary position

[DevTools] Support async step in from arbitrary position

We first continue to call location, then async step in.

BUG=none

Review-Url: https://codereview.chromium.org/2881893002
Cr-Commit-Position: refs/heads/master@{#471517}
Committed: https://chromium.googlesource.com/chromium/src/+/ca179d80c8bdd013f79d695748f07f003e76e903

[dgozman, 2017-05-12 18:00:06]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-05-12 18:00:07]

Could you please take a look?

[lushnikov, 2017-05-12 19:47:58]

lgtm

https://codereview.chromium.org/2881893002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2881893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:520:
var line = event.target.enclosingNodeOrSelfWithClass('CodeMirror-line');
let's use codemirror's coordinatesToCursorPosition to not poke into cm's
internals

https://codereview.chromium.org/2881893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:530:
if (this._asyncStepInElement === element && this._asyncStepInHighlight ===
highlight)
Let's rename _asyncStepInElement into _highlightAsyncStepInElement

[dgozman, 2017-05-12 21:02:39]

https://codereview.chromium.org/2881893002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2881893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:520:
var line = event.target.enclosingNodeOrSelfWithClass('CodeMirror-line');
On 2017/05/12 19:47:57, lushnikov wrote:
> let's use codemirror's coordinatesToCursorPosition to not poke into cm's
> internals

Done.

https://codereview.chromium.org/2881893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:530:
if (this._asyncStepInElement === element && this._asyncStepInHighlight ===
highlight)
On 2017/05/12 19:47:57, lushnikov wrote:
> Let's rename _asyncStepInElement into _highlightAsyncStepInElement

Done.

[dgozman, 2017-05-12 22:58:13]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-05-12 22:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2881893002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-05-12 22:59:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 01:03:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494629893806960,
"parent_rev": "83c68150757cf0f8ff866ababc1e95f6df913e6d", "commit_rev":
"ca179d80c8bdd013f79d695748f07f003e76e903"}

[commit-bot: I haz the power, 2017-05-13 01:03:40]

Description was changed from

==========
[DevTools] Support async step in from arbitrary position

We first continue to call location, then async step in.

BUG=none
==========

to

==========
[DevTools] Support async step in from arbitrary position

We first continue to call location, then async step in.

BUG=none

Review-Url: https://codereview.chromium.org/2881893002
Cr-Commit-Position: refs/heads/master@{#471517}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca179d80c8bdd013f79d695748f0...
==========

[commit-bot: I haz the power, 2017-05-13 01:03:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca179d80c8bdd013f79d695748f0...