Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2880863002: [DevTools] Handle more cases for async step in markers (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Handle more cases for async step in markers Also added a test. BUG=none Review-Url: https://codereview.chromium.org/2880863002 Cr-Commit-Position: refs/heads/master@{#471621} Committed: https://chromium.googlesource.com/chromium/src/+/0d4efb2fa21de85b0b5637e151447a4e23c81b06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -17 lines) Patch
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/continue-to-location-markers.html View 1 chunk +119 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/continue-to-location-markers-expected.txt View 1 chunk +104 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +86 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
dgozman
Please take a look.
3 years, 7 months ago (2017-05-12 23:00:20 UTC) #2
kozy
lgtm % please add continue to location marker for debugger!
3 years, 7 months ago (2017-05-12 23:47:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880863002/1
3 years, 7 months ago (2017-05-13 15:36:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/443896)
3 years, 7 months ago (2017-05-13 17:26:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880863002/1
3 years, 7 months ago (2017-05-14 01:02:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-14 08:23:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d4efb2fa21de85b0b5637e15144...

Powered by Google App Engine
This is Rietveld 408576698