Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2881793002: Revert of Allocate memory in smaller chunks for chrome://memory-exhaust/ (Closed)

Created:
3 years, 7 months ago by hans
Modified:
3 years, 7 months ago
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allocate memory in smaller chunks for chrome://memory-exhaust/ (patchset #1 id:1 of https://codereview.chromium.org/2882513003/ ) Reason for revert: This fixed the test in one build configuration but made it hang in another one instead (see bug). I'll come up with a less magic and more effective fix. Original issue's description: > Allocate memory in smaller chunks for chrome://memory-exhaust/ > > The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang > in certain build configs (32-bit Windows Clang debug builds), causing > MetricsServiceBrowserTest.OOMRenderers to hang while generating the > backtrace after the OOM exception. Reducing the allocation size seems to > help. > > BUG=692564 > TBR=jochen > > Review-Url: https://codereview.chromium.org/2882513003 > Cr-Commit-Position: refs/heads/master@{#471138} > Committed: https://chromium.googlesource.com/chromium/src/+/7cf2f122818ad39afafea382ecf2a6cee9d350fd TBR=thakis@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692564 Review-Url: https://codereview.chromium.org/2881793002 Cr-Commit-Position: refs/heads/master@{#471331} Committed: https://chromium.googlesource.com/chromium/src/+/c3c52671bcb5680b267c80ffa951a61363aad5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hans
Created Revert of Allocate memory in smaller chunks for chrome://memory-exhaust/
3 years, 7 months ago (2017-05-12 16:40:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881793002/1
3 years, 7 months ago (2017-05-12 16:40:54 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:41:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3c52671bcb5680b267c80ffa951...

Powered by Google App Engine
This is Rietveld 408576698