Allocate memory in smaller chunks for chrome://memory-exhaust/

Allocate memory in smaller chunks for chrome://memory-exhaust/

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
TBR=jochen

Review-Url: https://codereview.chromium.org/2882513003
Cr-Commit-Position: refs/heads/master@{#471138}
Committed: https://chromium.googlesource.com/chromium/src/+/7cf2f122818ad39afafea382ecf2a6cee9d350fd

[hans, 2017-05-11 22:02:06]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 22:04:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2017-05-11 22:12:51]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2017-05-11 22:12:52]

Let's see if the buildbots like it, then please take a look.

[hans, 2017-05-11 22:13:21]

hans@chromium.org changed reviewers:
+ jochen@chromium.org

[hans, 2017-05-11 22:13:21]

+jochen for ownership, and I think you might have written or touched this code

[Nico, 2017-05-11 22:14:24]

I vaguely remember that Will touched this code at some point, so +him

lgtm – a bit magical, but hey.

[Nico, 2017-05-11 22:15:25]

And I think this CL is inconsequential enough that you can TBR (especially given
that only FYI bots can tell us if it actually helped and they'll probably have
to cycle over night)

[Will Harris, 2017-05-11 22:18:26]

oh wow nice find, I'm amazed this makes a difference... lgtm if the bots like
it.

[commit-bot: I haz the power, 2017-05-11 22:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 22:49:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hans, 2017-05-11 23:14:44]

On 2017/05/11 22:15:25, Nico wrote:
> And I think this CL is inconsequential enough that you can TBR (especially
given
> that only FYI bots can tell us if it actually helped and they'll probably have
> to cycle over night)

OK, let's do that.

[hans, 2017-05-11 23:14:56]

Description was changed from

==========
Allocate memory in smaller chunks for chrome://memory-exhaust/

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
==========

to

==========
Allocate memory in smaller chunks for chrome://memory-exhaust/

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
TBR=jochen
==========

[hans, 2017-05-11 23:14:59]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:15:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 00:19:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494544499803320, "parent_rev":
"fe27ed665852a667acdba62f8a77a1d9969170da", "commit_rev":
"7cf2f122818ad39afafea382ecf2a6cee9d350fd"}

[commit-bot: I haz the power, 2017-05-12 00:19:22]

Description was changed from

==========
Allocate memory in smaller chunks for chrome://memory-exhaust/

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
TBR=jochen
==========

to

==========
Allocate memory in smaller chunks for chrome://memory-exhaust/

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
TBR=jochen

Review-Url: https://codereview.chromium.org/2882513003
Cr-Commit-Position: refs/heads/master@{#471138}
Committed:
https://chromium.googlesource.com/chromium/src/+/7cf2f122818ad39afafea382ecf2...
==========

[commit-bot: I haz the power, 2017-05-12 00:19:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cf2f122818ad39afafea382ecf2...

[hans, 2017-05-12 16:40:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2881793002/ by hans@chromium.org.

The reason for reverting is: This fixed the test in one build configuration but
made it hang in another one instead (see bug).

I'll come up with a less magic and more effective fix..