[ServiceWorker] Revise wpt tests for Client.type

[ServiceWorker] Revise wpt tests for Client.type

For tests related with Client.type,
'
- Verify that the WPT test is a superset of the chromium/ tests.
- Delete the chromium/ tests
'
chromium/clients-get-client-types.html
--> covered by wpt clients-get-client-types.https.html
chromium/{clients-matchall.html, clients-matchall-include-uncontrolled.html}
--> covered by wpt clients-matchall*.https.html

BUG=705685
TEST=blink_tests

Review-Url: https://codereview.chromium.org/2881743002
Cr-Commit-Position: refs/heads/master@{#471995}
Committed: https://chromium.googlesource.com/chromium/src/+/311cc352fa99a028311cab7d6af9d6cd9a6d610e

[leonhsl(Using Gerrit), 2017-05-12 11:39:25]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 11:39:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 13:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 13:15:02]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-05-15 02:23:18]

leon.han@intel.com changed reviewers:
+ falken@chromium.org

[leonhsl(Using Gerrit), 2017-05-15 02:23:19]

Hi, falken@, PTAL, Thanks! This CL is to
'
- Verify that the WPT test is a superset of the chromium/ tests.
- Delete the chromium/ tests
'
chromium/clients-get-client-types.html --> covered by wpt
clients-get-client-types.https.html
chromium/{clients-matchall.html, clients-matchall-include-uncontrolled.html} -->
covered by wpt clients-matchall*.https.html

And I'd like to do following work with another separate CL as it has no
dependency relationship with this CL.
'
- Add Client.type testing to all three WPT tests that don't have it.
'

[leonhsl(Using Gerrit), 2017-05-15 02:28:18]

Description was changed from

==========
[ServiceWorker] Revise wpt tests for Client.type

BUG=705685
TEST=blink_tests
==========

to

==========
[ServiceWorker] Revise wpt tests for Client.type

For tests related with Client.type,
'
- Verify that the WPT test is a superset of the chromium/ tests.
- Delete the chromium/ tests
'
chromium/clients-get-client-types.html
--> covered by wpt clients-get-client-types.https.html
chromium/{clients-matchall.html, clients-matchall-include-uncontrolled.html}
--> covered by wpt clients-matchall*.https.html

BUG=705685
TEST=blink_tests
==========

[falken, 2017-05-15 06:39:28]

lgtm, thanks!

I think you basically already did step 3. The only thing missing AFAICT is
testing when Client.type is 'worker'. Adding a test in
clients-get-client-types.https.html should address that.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html:65:
/* visibilityState, focused, url, type, frameType */
nit: while here can you change this to a // style comment? we don't really use
/* comments */

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html:63:
/* visibilityState, focused, url, type, frameType */
nit: comment style

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html:31:
/* visibilityState, focused, url, type, frameType */
nit: comment style

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html:30:
/* visibilityState, focused, url, type, frameType */
comment style

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html:36:
/* visibilityState, focused, url, type, frameType */
comment style

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall.https.html:33:
/* visibilityState, focused, url, type, frameType */
comment style

[leonhsl(Using Gerrit), 2017-05-15 11:05:17]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 11:05:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 12:14:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 12:14:13]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-05-16 02:54:29]

Thanks a lot for review! Within this CL I wanted to add a test into
clients-get-client-types.https.html for Client.type 'worker', but encountered
some problems, so I uploaded another separate CL for that, and would like to
land this CL now.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html:65:
/* visibilityState, focused, url, type, frameType */
On 2017/05/15 06:39:28, falken wrote:
> nit: while here can you change this to a // style comment? we don't really use
> /* comments */

Done.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html:63:
/* visibilityState, focused, url, type, frameType */
On 2017/05/15 06:39:28, falken wrote:
> nit: comment style

Done.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html:31:
/* visibilityState, focused, url, type, frameType */
On 2017/05/15 06:39:28, falken wrote:
> nit: comment style

Done.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html:30:
/* visibilityState, focused, url, type, frameType */
On 2017/05/15 06:39:28, falken wrote:
> comment style

Done.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html:36:
/* visibilityState, focused, url, type, frameType */
On 2017/05/15 06:39:28, falken wrote:
> comment style

Done.

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall.https.html
(right):

https://codereview.chromium.org/2881743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall.https.html:33:
/* visibilityState, focused, url, type, frameType */
On 2017/05/15 06:39:28, falken wrote:
> comment style

Done.

[leonhsl(Using Gerrit), 2017-05-16 02:54:35]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-05-16 02:54:36]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2881743002/#ps20001
(title: "Revise code comments")

[commit-bot: I haz the power, 2017-05-16 02:54:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:59:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494903275879200,
"parent_rev": "6eecabd7b0f4d82b3d5a452716c3f02d546d4c96", "commit_rev":
"311cc352fa99a028311cab7d6af9d6cd9a6d610e"}

[commit-bot: I haz the power, 2017-05-16 03:00:04]

Description was changed from

==========
[ServiceWorker] Revise wpt tests for Client.type

For tests related with Client.type,
'
- Verify that the WPT test is a superset of the chromium/ tests.
- Delete the chromium/ tests
'
chromium/clients-get-client-types.html
--> covered by wpt clients-get-client-types.https.html
chromium/{clients-matchall.html, clients-matchall-include-uncontrolled.html}
--> covered by wpt clients-matchall*.https.html

BUG=705685
TEST=blink_tests
==========

to

==========
[ServiceWorker] Revise wpt tests for Client.type

For tests related with Client.type,
'
- Verify that the WPT test is a superset of the chromium/ tests.
- Delete the chromium/ tests
'
chromium/clients-get-client-types.html
--> covered by wpt clients-get-client-types.https.html
chromium/{clients-matchall.html, clients-matchall-include-uncontrolled.html}
--> covered by wpt clients-matchall*.https.html

BUG=705685
TEST=blink_tests

Review-Url: https://codereview.chromium.org/2881743002
Cr-Commit-Position: refs/heads/master@{#471995}
Committed:
https://chromium.googlesource.com/chromium/src/+/311cc352fa99a028311cab7d6af9...
==========

[commit-bot: I haz the power, 2017-05-16 03:00:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/311cc352fa99a028311cab7d6af9...