third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html - Issue 2881743002: [ServiceWorker] Revise wpt tests for Client.type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html

Issue 2881743002: [ServiceWorker] Revise wpt tests for Client.type (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html ('k') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Service Worker: Clients.get</title>	2 <title>Service Worker: Clients.get</title>

3 <script src="/resources/testharness.js"></script>	3 <script src="/resources/testharness.js"></script>

4 <script src="/resources/testharnessreport.js"></script>	4 <script src="/resources/testharnessreport.js"></script>

5 <script src="resources/test-helpers.sub.js"></script>	5 <script src="resources/test-helpers.sub.js"></script>

6 <script>	6 <script>

7 var scope = 'resources/clients-get-frame.html';	7 var scope = 'resources/clients-get-frame.html';

8 var client_ids = [];	8 var client_ids = [];

9 var frame;	9 var frame;

10 promise_test(function(t) {	10 promise_test(function(t) {

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 return new Promise(function(resolve, reject) {	53 return new Promise(function(resolve, reject) {

54 function get_client_id(e) {	54 function get_client_id(e) {

55 window.removeEventListener('message', get_client_id);	55 window.removeEventListener('message', get_client_id);

56 resolve(e.data.clientId);	56 resolve(e.data.clientId);

57 }	57 }

58 window.addEventListener('message', get_client_id, false);	58 window.addEventListener('message', get_client_id, false);

59 });	59 });

60 }	60 }

61	61

62 var expected = [	62 var expected = [

63 /* visibilityState, focused, url, frameType */	63 /* visibilityState, focused, url, type, frameType */
	falken 2017/05/15 06:39:28 nit: comment style nit: comment style leonhsl(Using Gerrit) 2017/05/16 02:54:28 Done. Show quoted text On 2017/05/15 06:39:28, falken wrote: > nit: comment style Done.
64 ['visible', true, normalizeURL(scope) + '#1', 'nested'],	64 ['visible', true, normalizeURL(scope) + '#1', 'window', 'nested'],

65 ['visible', false, normalizeURL(scope) + '#2', 'nested'],	65 ['visible', false, normalizeURL(scope) + '#2', 'window', 'nested'],

66 undefined	66 undefined

67 ];	67 ];

68 </script>	68 </script>

OLD	NEW