Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2881603002:
Remove the presubmit check that counts the number of owners (Closed)
DescriptionRemove the presubmit check that counts the number of owners
https: //codereview.chromium.org/2877553003/)
Review-Url: https://codereview.chromium.org/2881603002
Cr-Commit-Position: refs/heads/master@{#471079}
Committed: https://chromium.googlesource.com/chromium/src/+/51d2ef457b0e77fa0f170f1a5ca89d039cf69b04
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
nednguyen@google.com changed reviewers: + charliea@chromium.org, sullivan@chromium.org
Description was changed from ========== Remove the presubmit check that counts the number of owners This doesn't work for cases OWNERS file referencing other OWNERS file (see https://codereview.chromium.org/2877553003/) ========== to ========== Remove the presubmit check that counts the number of owners This doesn't work for cases OWNERS file referencing other OWNERS file (see https://codereview.chromium.org/2877553003/) ==========
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove the presubmit check that counts the number of owners This doesn't work for cases OWNERS file referencing other OWNERS file (see https://codereview.chromium.org/2877553003/) ========== to ========== Remove the presubmit check that counts the number of owners This doesn't work for cases OWNERS file referencing other OWNERS file (see https://codereview.chromium.org/2877553003/) NOTRY=true ==========
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494537417818610, "parent_rev":
"970e26717675d235f8dc59c1646e4abf9e3a7784", "commit_rev":
"0ff0addda7d21c931e9460b0e68c020b58d59bc5"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494537417818610, "parent_rev":
"6a960f89971032ab3809d50a4116c0f40c877fd3", "commit_rev":
"51d2ef457b0e77fa0f170f1a5ca89d039cf69b04"}
Message was sent while issue was closed.
Description was changed from ========== Remove the presubmit check that counts the number of owners This doesn't work for cases OWNERS file referencing other OWNERS file (see https://codereview.chromium.org/2877553003/) NOTRY=true ========== to ========== Remove the presubmit check that counts the number of owners https: //codereview.chromium.org/2877553003/) Review-Url: https://codereview.chromium.org/2881603002 Cr-Commit-Position: refs/heads/master@{#471079} Committed: https://chromium.googlesource.com/chromium/src/+/51d2ef457b0e77fa0f170f1a5ca8... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/51d2ef457b0e77fa0f170f1a5ca8... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
