tools/perf/contrib/PRESUBMIT.py - Issue 2881603002: Remove the presubmit check that counts the number of owners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/contrib/PRESUBMIT.py

Issue 2881603002: Remove the presubmit check that counts the number of owners (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/contrib/PRESUBMIT.py

diff --git a/tools/perf/contrib/PRESUBMIT.py b/tools/perf/contrib/PRESUBMIT.py

index 38f2a046b110ce458a9f784cf1ad406f17e23e57..86f75f0fe93129d34b5076df49bae16c35e8cc53 100644

--- a/tools/perf/contrib/PRESUBMIT.py

+++ b/tools/perf/contrib/PRESUBMIT.py

@@ -17,15 +17,6 @@ def _CheckOwnershipForContribSubDir(sub_dir, input_api, output_api):

if not input_api.os_path.isfile(owner_file):

results.append(output_api.PresubmitError(

'%s must have an OWNERS file' % sub_dir))

- else:

- owners = []

- with open(owner_file) as f:

- for line in f:

- if line.strip() and not line.strip().startswith('#'):

- owners.append(line)

- if len(owners) < 2:

- results.append(output_api.PresubmitError(

- '%s must have at least 2 owners' % owner_file))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »