Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2881213004: [milo] fix raw annotation stream rendering endpoint. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
dnj, nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[milo] fix raw annotation stream rendering endpoint. Previously this was just plain broken (path v. prefix param). Now you can take a log_location annotation (everything after `logdog://`) from a swarming task and paste it at the end of: <milo-app>.appspot.com/raw/build/<paste> And get a sensible build page. R=dnj@chromium.org, hinoka@chromium.org, nodir@chromium.org BUG= Review-Url: https://codereview.chromium.org/2881213004 Committed: https://github.com/luci/luci-go/commit/8f9ef0bee3bc616811ad9969513be3871aea94cd

Patch Set 1 #

Patch Set 2 : make url scheme better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M milo/appengine/frontend/main.go View 1 1 chunk +3 lines, -1 line 0 comments Download
M milo/appengine/logdog/html.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
iannucci
3 years, 7 months ago (2017-05-16 09:12:01 UTC) #1
iannucci
Example: https://1733-73e93dd-tainted-iannucci-dot-luci-milo-dev.appspot.com/raw/build/luci-logdog-dev.appspot.com/infra/buildbucket/cr-buildbucket-dev.appspot.com/8979453519563643888/+/annotations
3 years, 7 months ago (2017-05-16 09:26:58 UTC) #8
nodir
lgtm
3 years, 6 months ago (2017-05-25 19:53:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881213004/20001
3 years, 6 months ago (2017-05-25 21:04:18 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 21:09:44 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/8f9ef0bee3bc616811ad9969513be3871aea94cd

Powered by Google App Engine
This is Rietveld 408576698