Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3396)

Unified Diff: milo/appengine/logdog/html.go

Issue 2881213004: [milo] fix raw annotation stream rendering endpoint. (Closed)
Patch Set: make url scheme better Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/frontend/main.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/logdog/html.go
diff --git a/milo/appengine/logdog/html.go b/milo/appengine/logdog/html.go
index 3bbfc8c96654c66b812e8edcc41dd67cabe55ce0..fa547fd778112e80a3288e38c8931bd64b05f523 100644
--- a/milo/appengine/logdog/html.go
+++ b/milo/appengine/logdog/html.go
@@ -36,7 +36,6 @@ func BuildHandler(c *router.Context) {
// Render implements settings.ThemedHandler.
func (s *AnnotationStreamHandler) Render(c *router.Context) {
-
as := AnnotationStream{
Project: cfgtypes.ProjectName(c.Params.ByName("project")),
Path: types.StreamPath(strings.Trim(c.Params.ByName("path"), "/")),
@@ -48,7 +47,8 @@ func (s *AnnotationStreamHandler) Render(c *router.Context) {
// Setup our LogDog client.
var err error
- if as.Client, err = NewClient(c.Context, ""); err != nil {
+ host := strings.TrimSpace(c.Params.ByName("logdog_host"))
+ if as.Client, err = NewClient(c.Context, host); err != nil {
log.WithError(err).Errorf(c.Context, "Failed to generate LogDog client.")
common.ErrorPage(c, http.StatusInternalServerError, "Failed to generate LogDog client")
return
« no previous file with comments | « milo/appengine/frontend/main.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698