Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2881033003:
[Password Manager] Send a request to the store if user clicks on an undetected password field (Closed)
|
Created:
3 years, 7 months ago by kolos1 Modified:
3 years, 7 months ago Reviewers:
dvadym CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Password Manager] Send a request to the store if user clicks on a password field that we didn't detect
For some reason, the password manager might miss that there is a password field on the page (e.g. dynamic form, a field that changed the type from 'text' to 'password'). If a user clicks on the password field, but there was no request to the password store, then fetch saved credentials on click. When the response is received, the manual fallback for filling will be available.
BUG=721716
Review-Url: https://codereview.chromium.org/2881033003
Cr-Commit-Position: refs/heads/master@{#472767}
Committed: https://chromium.googlesource.com/chromium/src/+/9436e7c73362bf570dac89cf60c06e5a9a858e87
Patch Set 1 : #
Total comments: 2
Patch Set 2 : Test patch set with DCHECK #Patch Set 3 : #Patch Set 4 : Rebase #
Messages
Total messages: 29 (23 generated)
Description was changed from ========== [Password Manager] Send a request to the store if user clicks on a password field that we didn't detect BUG=721716 ========== to ========== [Password Manager] Send a request to the store if user clicks on a password field that we didn't detect For some reason, the password manager might miss that there is a password field on the page (e.g. dynamic form, a field that changed the type from 'text' to 'password'). If a user clicks on the password field, but there was no request to the password store, then fetch saved credentials on click. When the response is received, the manual fallback for filling will be available. BUG=721716 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
kolos@chromium.org changed reviewers: + dvadym@chromium.org
Hi Vadym, Please review this CL. Regards, Maxim
The CQ bit was checked by kolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for implementing this fallback. LGTM % nit https://codereview.chromium.org/2881033003/diff/40001/components/autofill/con... File components/autofill/content/renderer/password_autofill_agent.cc (right): https://codereview.chromium.org/2881033003/diff/40001/components/autofill/con... components/autofill/content/renderer/password_autofill_agent.cc:892: SendPasswordForms(false); Nit: We could make return from this function. If no request was sent, all other part of this function doesn't make any sense.
The CQ bit was checked by kolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:80001) has been deleted
The CQ bit was checked by kolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kolos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2881033003/diff/40001/components/autofill/con... File components/autofill/content/renderer/password_autofill_agent.cc (right): https://codereview.chromium.org/2881033003/diff/40001/components/autofill/con... components/autofill/content/renderer/password_autofill_agent.cc:892: SendPasswordForms(false); On 2017/05/16 12:13:48, dvadym wrote: > Nit: We could make return from this function. If no request was sent, all other > part of this function doesn't make any sense. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by kolos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org Link to the patchset: https://codereview.chromium.org/2881033003/#ps100001 (title: " ")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kolos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org Link to the patchset: https://codereview.chromium.org/2881033003/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495104179878090,
"parent_rev": "c94fe676d2844538ccbe94c15f53fb4cbb3971cf", "commit_rev":
"9436e7c73362bf570dac89cf60c06e5a9a858e87"}
Message was sent while issue was closed.
Description was changed from ========== [Password Manager] Send a request to the store if user clicks on a password field that we didn't detect For some reason, the password manager might miss that there is a password field on the page (e.g. dynamic form, a field that changed the type from 'text' to 'password'). If a user clicks on the password field, but there was no request to the password store, then fetch saved credentials on click. When the response is received, the manual fallback for filling will be available. BUG=721716 ========== to ========== [Password Manager] Send a request to the store if user clicks on a password field that we didn't detect For some reason, the password manager might miss that there is a password field on the page (e.g. dynamic form, a field that changed the type from 'text' to 'password'). If a user clicks on the password field, but there was no request to the password store, then fetch saved credentials on click. When the response is received, the manual fallback for filling will be available. BUG=721716 Review-Url: https://codereview.chromium.org/2881033003 Cr-Commit-Position: refs/heads/master@{#472767} Committed: https://chromium.googlesource.com/chromium/src/+/9436e7c73362bf570dac89cf60c0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as https://chromium.googlesource.com/chromium/src/+/9436e7c73362bf570dac89cf60c0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
