[Password Manager] Send a request to the store if user clicks on an undetected password field

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 868 matching lines @@
     const blink::WebInputElement& element,
     blink::WebInputElement* username_element,
     blink::WebInputElement* password_element,
     PasswordInfo** password_info) {
   DCHECK(username_element && password_element && password_info);
   username_element->Reset();
   password_element->Reset();
   if (!element.IsPasswordField()) {
     *username_element = element;
   } else {
+    // If there is a password field, but a request to the store hasn't been sent
+    // yet, then do fetch saved credentials now.
+    if (!sent_request_to_store_)
+      SendPasswordForms(false);

[dvadym, 2017/05/16 12:13:48]

Nit: We could make return from this function. If no request was sent, all other
part of this function doesn't make any sense.

[kolos1, 2017/05/17 09:05:30]

Done.

+
     WebInputToPasswordInfoMap::iterator iter =
         web_input_to_password_info_.find(element);
     if (iter != web_input_to_password_info_.end()) {
       // It's a password field without corresponding username field.
       *password_element = element;
       *password_info = &iter->second;
       return true;
     }
     PasswordToLoginMap::const_iterator password_iter =
         password_to_username_.find(element);
@@ skipping 318 matching lines @@
         HasPasswordField(*frame)) {
       // Set everything that |FormDigest| needs.
       password_forms.push_back(PasswordForm());
       password_forms.back().scheme = PasswordForm::SCHEME_HTML;
       password_forms.back().origin =
           form_util::GetCanonicalOriginForDocument(frame->GetDocument());
       GURL::Replacements rep;
       rep.SetPathStr("");
       password_forms.back().signon_realm =
           password_forms.back().origin.ReplaceComponents(rep).spec();
+    }
+    if (!password_forms.empty()) {
       sent_request_to_store_ = true;
+      GetPasswordManagerDriver()->PasswordFormsParsed(password_forms);
     }
-    if (!password_forms.empty())
-      GetPasswordManagerDriver()->PasswordFormsParsed(password_forms);
   }
 }
 
 void PasswordAutofillAgent::DidFinishDocumentLoad() {
   // The |frame| contents have been parsed, but not yet rendered.  Let the
   // PasswordManager know that forms are loaded, even though we can't yet tell
   // whether they're visible.
   form_util::ScopedLayoutPreventer layout_preventer;
   SendPasswordForms(false);
 }
@@ skipping 483 matching lines @@
 PasswordAutofillAgent::GetPasswordManagerDriver() {
   if (!password_manager_driver_) {
     render_frame()->GetRemoteInterfaces()->GetInterface(
         mojo::MakeRequest(&password_manager_driver_));
   }
 
   return password_manager_driver_;
 }
 
 }  // namespace autofill