Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2880963003: Revert of Move AppliedTextDecorationList to its own file. (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move AppliedTextDecorationList to its own file. (patchset #2 id:20001 of https://codereview.chromium.org/2884553002/ ) Reason for revert: Reverting since the BUILD file wasn't updated. Author is aware Original issue's description: > Move AppliedTextDecorationList to its own file. > > When we generate external types like Length in ComputedStyle, we specify > the path to the type (e.g. "platform/Length"). We then deduce the name > of the type from the path ("Length"). This means that the type must be > stored in a file with the same name. > > This patch moves AppliedTextDecorationList to its own file so that it > can be generated. > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2884553002 > Cr-Commit-Position: refs/heads/master@{#471653} > Committed: https://chromium.googlesource.com/chromium/src/+/762e2d87addf15f32ac5bda17b1ad9a8fb25dee2 TBR=suzyh@chromium.org,shend@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628043 Review-Url: https://codereview.chromium.org/2880963003 Cr-Commit-Position: refs/heads/master@{#471656} Committed: https://chromium.googlesource.com/chromium/src/+/79f466d744b7c279c939c27877ae261d02f966b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
D third_party/WebKit/Source/core/style/AppliedTextDecorationList.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
nainar
Created Revert of Move AppliedTextDecorationList to its own file.
3 years, 7 months ago (2017-05-15 03:41:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880963003/1
3 years, 7 months ago (2017-05-15 03:41:41 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/style/StyleRareInheritedData.h: While running git apply --index -3 -p1; error: patch ...
3 years, 7 months ago (2017-05-15 03:42:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880963003/1
3 years, 7 months ago (2017-05-15 03:43:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/79f466d744b7c279c939c27877ae261d02f966b2
3 years, 7 months ago (2017-05-15 03:43:42 UTC) #10
suzyh_UTC10 (ex-contributor)
3 years, 7 months ago (2017-05-15 04:31:59 UTC) #11
Message was sent while issue was closed.
lgtm

How did the patch land if it did not have the required BUILD changes?

Powered by Google App Engine
This is Rietveld 408576698