Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2880843002: Use ui::AX_EVENT_SELECTION to read aloud omnibox suggestion answers. (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Use ui::AX_EVENT_SELECTION to read aloud omnibox suggestion answers. The previous approach (ui::AX_EVENT_ALERT) allowed the speaking to be interrupted by other events. BUG=714148 Review-Url: https://codereview.chromium.org/2871973002 Cr-Original-Commit-Position: refs/heads/master@{#470404} Review-Url: https://codereview.chromium.org/2880843002 . Cr-Commit-Position: refs/branch-heads/3071@{#536} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b643f525589405784c8e465cd5eae3304bac85c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Justin Donnelly
3 years, 7 months ago (2017-05-12 20:02:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b643f525589405784c8e465cd5eae3304bac85c9.

Powered by Google App Engine
This is Rietveld 408576698