Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2871973002: Use ui::AX_EVENT_SELECTION to read aloud omnibox suggestion answers. (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, jdonnelly+watch_chromium.org, David Tseng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ui::AX_EVENT_SELECTION to read aloud omnibox suggestion answers. The previous approach (ui::AX_EVENT_ALERT) allowed the speaking to be interrupted by other events. BUG=714148 Review-Url: https://codereview.chromium.org/2871973002 Cr-Commit-Position: refs/heads/master@{#470404} Committed: https://chromium.googlesource.com/chromium/src/+/97e8179a439eb85276dd8fefa806133b1c965eca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Justin Donnelly
3 years, 7 months ago (2017-05-09 15:32:38 UTC) #4
Peter Kasting
RS LGTM
3 years, 7 months ago (2017-05-09 17:46:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871973002/1
3 years, 7 months ago (2017-05-09 18:36:49 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 19:18:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97e8179a439eb85276dd8fefa806...

Powered by Google App Engine
This is Rietveld 408576698