diagnose_bloat.py: disable --cloud for Linux.

diagnose_bloat.py: disable --cloud for Linux.

Map file generation is disabled on Linux Builders (see
http://crbug.com/716209), so the script fails if Linux is used with
--cloud.

BUG=717550
Review-Url: https://codereview.chromium.org/2880793002
Cr-Commit-Position: refs/heads/master@{#472207}
Committed: https://chromium.googlesource.com/chromium/src/+/fd56e2325de0fd7358d2edba992c6301392674a9

[estevenson, 2017-05-12 17:20:32]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-05-12 17:20:33]

ptal Andrew

[estevenson, 2017-05-12 17:35:42]

On 2017/05/12 17:20:33, estevenson wrote:
> ptal Andrew

Output directory detection was failing because build.ninja doesn't exist anymore
(I'm assuming this was changed when we changed what gets archived on the bots?)

[estevenson, 2017-05-15 20:36:05]

Gahh after lots of fiddling around I think this is the most reasonable thing to
do:
  * Linux diffs are useless right now so we might as well disable them
  * Running supersize archive on a downloaded linux dir (waiting for a local
build as well) hits this error:
E   1861 ELF file and .map file do not agree on section sizes.

I'll update the commit message if you agree.

[agrieve, 2017-05-16 00:26:00]

lgtm

https://codereview.chromium.org/2880793002/diff/80001/tools/binary_size/diagn...
File tools/binary_size/diagnose_bloat.py (right):

https://codereview.chromium.org/2880793002/diff/80001/tools/binary_size/diagn...
tools/binary_size/diagnose_bloat.py:762: parser.error('--target-os linux
doesn\'t work with --cloud')
nit: Maybe just add a comment saying that it doesn't work because the bots don't
run supersize,

[estevenson, 2017-05-16 18:57:21]

Description was changed from

==========
diagnose_bloat.py: fix broken tool and output directory detection.

Updates the supersize archive command so that output directories and
source paths are used appropriately.

Also changes supersize archive to run even when the output directory
can't be detected.

BUG=695182
==========

to

==========
diagnose_bloat.py: disable --cloud for Linux.

Map file generation is disabled on Linux Builders (see
http://crbug.com/716209), so the script fails if Linux is used with
--cloud.

BUG=717550
==========

[estevenson, 2017-05-16 19:02:09]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-05-16 19:02:09]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2880793002/#ps100001
(title: "reason why --cloud and linux don't work together")

[commit-bot: I haz the power, 2017-05-16 19:04:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:13:48]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[estevenson, 2017-05-16 20:08:47]

https://codereview.chromium.org/2880793002/diff/80001/tools/binary_size/diagn...
File tools/binary_size/diagnose_bloat.py (right):

https://codereview.chromium.org/2880793002/diff/80001/tools/binary_size/diagn...
tools/binary_size/diagnose_bloat.py:762: parser.error('--target-os linux
doesn\'t work with --cloud')
On 2017/05/16 00:26:00, agrieve wrote:
> nit: Maybe just add a comment saying that it doesn't work because the bots
don't
> run supersize, 

Done.

[estevenson, 2017-05-16 20:08:51]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:10:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 20:36:54]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494965331700280,
"parent_rev": "d8b7adbe4b26fedd0a87ffd74aaac141a4694490", "commit_rev":
"fd56e2325de0fd7358d2edba992c6301392674a9"}

[commit-bot: I haz the power, 2017-05-16 20:37:04]

Description was changed from

==========
diagnose_bloat.py: disable --cloud for Linux.

Map file generation is disabled on Linux Builders (see
http://crbug.com/716209), so the script fails if Linux is used with
--cloud.

BUG=717550
==========

to

==========
diagnose_bloat.py: disable --cloud for Linux.

Map file generation is disabled on Linux Builders (see
http://crbug.com/716209), so the script fails if Linux is used with
--cloud.

BUG=717550

Review-Url: https://codereview.chromium.org/2880793002
Cr-Commit-Position: refs/heads/master@{#472207}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd56e2325de0fd7358d2edba992c...
==========

[commit-bot: I haz the power, 2017-05-16 20:37:05]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fd56e2325de0fd7358d2edba992c...