Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: tools/binary_size/diagnose_bloat.py

Issue 2880793002: diagnose_bloat.py: disable --cloud for Linux. (Closed)
Patch Set: reason why --cloud and linux don't work together Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/diagnose_bloat.py
diff --git a/tools/binary_size/diagnose_bloat.py b/tools/binary_size/diagnose_bloat.py
index 37b5e88690d9a7363d0c990e8113dddf15f20e83..d5473eb41e7e6d50f1ff17c983a9a62b77a9d088 100755
--- a/tools/binary_size/diagnose_bloat.py
+++ b/tools/binary_size/diagnose_bloat.py
@@ -755,8 +755,13 @@ def main():
logging.basicConfig(level=log_level,
format='%(levelname).1s %(relativeCreated)6d %(message)s')
build = _BuildHelper(args)
- if build.IsCloud() and args.subrepo:
+ if build.IsCloud():
+ if args.subrepo:
parser.error('--subrepo doesn\'t work with --cloud')
+ if build.IsLinux():
+ parser.error('--target-os linux doesn\'t work with --cloud because map '
+ 'files aren\'t generated by builders (crbug.com/716209).')
+
subrepo = args.subrepo or _SRC_ROOT
_EnsureDirectoryClean(subrepo)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698