Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: components/sync/user_events/user_event_service.h

Issue 2880683002: Adding RegisterDependantFieldTrial interface method. (Closed)
Patch Set: Adding proto_visitors.h change. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/user_events/user_event_service.h
diff --git a/components/sync/user_events/user_event_service.h b/components/sync/user_events/user_event_service.h
index f460d6c358bf5e30f71e5459aadd8a1e6e07f8db..d84d8d5d3018a808d956af5763d99797e9973056 100644
--- a/components/sync/user_events/user_event_service.h
+++ b/components/sync/user_events/user_event_service.h
@@ -6,14 +6,12 @@
#define COMPONENTS_SYNC_USER_EVENTS_USER_EVENT_SERVICE_H_
#include <memory>
+#include <string>
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "components/keyed_service/core/keyed_service.h"
-
-namespace sync_pb {
-class UserEventSpecifics;
-} // namespace sync_pb
+#include "components/sync/protocol/user_event_specifics.pb.h"
namespace syncer {
@@ -37,6 +35,12 @@ class UserEventService : public KeyedService {
void RecordUserEvent(std::unique_ptr<sync_pb::UserEventSpecifics> specifics);
void RecordUserEvent(const sync_pb::UserEventSpecifics& specifics);
+ // Register that knowledge about a given field trail is important when
Patrick Noland 2017/05/12 18:12:30 [nit] trial
skym 2017/05/12 21:05:38 Done.
+ // interpreting specified user event type, and should be recorded if assigned.
+ void RegisterDependantFieldTrial(
Patrick Noland 2017/05/12 18:12:30 [nit] Dependent
skym 2017/05/12 21:05:38 Done.
+ const std::string& trial_name,
+ sync_pb::UserEventSpecifics::EventCase event_case);
+
base::WeakPtr<ModelTypeSyncBridge> GetSyncBridge();
private:

Powered by Google App Engine
This is Rietveld 408576698