Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: components/sync/user_events/user_event_service.cc

Issue 2880683002: Adding RegisterDependantFieldTrial interface method. (Closed)
Patch Set: Adding proto_visitors.h change. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/user_events/user_event_service.cc
diff --git a/components/sync/user_events/user_event_service.cc b/components/sync/user_events/user_event_service.cc
index 328808b6dcbfd6d8fa9ed6eaf4a231e102f2633b..31155d063186e4f74b3836984e49b55d2cb84e21 100644
--- a/components/sync/user_events/user_event_service.cc
+++ b/components/sync/user_events/user_event_service.cc
@@ -13,20 +13,19 @@
#include "components/sync/driver/sync_driver_switches.h"
#include "components/sync/driver/sync_service.h"
#include "components/sync/model/model_type_sync_bridge.h"
-#include "components/sync/protocol/sync.pb.h"
#include "components/sync/user_events/user_event_sync_bridge.h"
using sync_pb::UserEventSpecifics;
namespace syncer {
-namespace {} // namespace
-
UserEventService::UserEventService(SyncService* sync_service,
std::unique_ptr<UserEventSyncBridge> bridge)
: sync_service_(sync_service),
bridge_(std::move(bridge)),
- session_id_(base::RandUint64()) {}
+ session_id_(base::RandUint64()) {
+ // TODO(skym): Subscribe to events about field trail membership changing.
Patrick Noland 2017/05/12 18:12:30 [nit] trial
skym 2017/05/12 21:05:37 Done.
+}
UserEventService::~UserEventService() {}
@@ -58,4 +57,9 @@ bool UserEventService::CanRecordEvent(const UserEventSpecifics& specifics) {
sync_service_->GetPreferredDataTypes().Has(HISTORY_DELETE_DIRECTIVES);
}
+void RegisterDependantFieldTrial(const std::string& trial_name,
Patrick Noland 2017/05/12 18:12:30 [nit] Dependent
skym 2017/05/12 21:05:37 Done.
+ UserEventSpecifics::EventCase event_case) {
+ // TODO(skym): Implementation.
+}
+
} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698