Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2880683002: Adding RegisterDependantFieldTrial interface method. (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 7 months ago
Reviewers:
bartekg, Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding RegisterDependantFieldTrial interface method. BUG=719038 Review-Url: https://codereview.chromium.org/2880683002 Cr-Commit-Position: refs/heads/master@{#471505} Committed: https://chromium.googlesource.com/chromium/src/+/1c31f37835d19c5bea950cf3fe05f8ebedf11574

Patch Set 1 #

Patch Set 2 : Fix compile. #

Patch Set 3 : Adding proto_visitors.h change. #

Total comments: 8

Patch Set 4 : Updates for Patrick. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M components/sync/protocol/proto_visitors.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M components/sync/protocol/user_event_specifics.proto View 1 2 chunks +9 lines, -1 line 0 comments Download
M components/sync/user_events/user_event_service.h View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M components/sync/user_events/user_event_service.cc View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
skym
PTAL
3 years, 7 months ago (2017-05-12 18:04:34 UTC) #13
Patrick Noland
lgtm https://codereview.chromium.org/2880683002/diff/40001/components/sync/user_events/user_event_service.cc File components/sync/user_events/user_event_service.cc (right): https://codereview.chromium.org/2880683002/diff/40001/components/sync/user_events/user_event_service.cc#newcode27 components/sync/user_events/user_event_service.cc:27: // TODO(skym): Subscribe to events about field trail ...
3 years, 7 months ago (2017-05-12 18:12:31 UTC) #14
skym
Updates for Patrick. https://codereview.chromium.org/2880683002/diff/40001/components/sync/user_events/user_event_service.cc File components/sync/user_events/user_event_service.cc (right): https://codereview.chromium.org/2880683002/diff/40001/components/sync/user_events/user_event_service.cc#newcode27 components/sync/user_events/user_event_service.cc:27: // TODO(skym): Subscribe to events about ...
3 years, 7 months ago (2017-05-12 21:05:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880683002/60001
3 years, 7 months ago (2017-05-12 21:08:34 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/453465)
3 years, 7 months ago (2017-05-12 22:49:28 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880683002/60001
3 years, 7 months ago (2017-05-12 22:57:42 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 00:17:32 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1c31f37835d19c5bea950cf3fe05...

Powered by Google App Engine
This is Rietveld 408576698