Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: components/sync/protocol/user_event_specifics.proto

Issue 2880683002: Adding RegisterDependantFieldTrial interface method. (Closed)
Patch Set: Updates for Patrick. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/protocol/proto_visitors.h ('k') | components/sync/user_events/user_event_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/user_event_specifics.proto
diff --git a/components/sync/protocol/user_event_specifics.proto b/components/sync/protocol/user_event_specifics.proto
index 8d3efd1b3126faa2dbe3bedd446c7c48bd381693..fa74e61191c68b9baa92b54ece3a38c978069253 100644
--- a/components/sync/protocol/user_event_specifics.proto
+++ b/components/sync/protocol/user_event_specifics.proto
@@ -13,6 +13,14 @@ option optimize_for = LITE_RUNTIME;
package sync_pb;
+message FieldTrialEvent {
+ message FieldTrial {
+ optional fixed32 name_id = 1;
+ optional fixed32 group_id = 2;
+ }
+ repeated FieldTrial field_trials = 1;
+}
+
message UserEventSpecifics {
// Time of event, as measured on the client (unix epoch).
optional int64 event_time_usec = 1;
@@ -24,5 +32,5 @@ message UserEventSpecifics {
// other events belonged to.
optional fixed64 session_id = 3;
- // TODO(skym): Wrap actual event payloads in a oneof.
+ oneof event { FieldTrialEvent field_trial_event = 4; }
}
« no previous file with comments | « components/sync/protocol/proto_visitors.h ('k') | components/sync/user_events/user_event_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698