Constrain ShortcutSource to valid values

Constrain ShortcutSource to valid values

When Chrome requests a WebAPK install, the WebAPK server uses the newest
available "WebAPK template". This means that if an old Chrome version
installs a WebAPK, it may have installed a WebAPK which sends
ShortcutSource values that the Chrome version does not support

This CL constrains the value of the ShortcutSource in the WebappLauncherActivity
launch intent to a valid value.

For instance, m58 Chrome does not know about ShortcutSource#EXTERNAL_INTENT
but the user might install a WebAPK which sends
source==ShortcutSource#EXTERNAL_INTENT to Chrome

BUG=711147
Review-Url: https://codereview.chromium.org/2880413002
Cr-Commit-Position: refs/heads/master@{#472632}
Committed: https://chromium.googlesource.com/chromium/src/+/257ccdb4fa9b6a50d24f0f736402874dab49a5d2

[pkotwicz, 2017-05-15 18:33:03]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2017-05-15 18:33:07]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2017-05-15 18:36:23]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2017-05-15 18:36:44]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-05-15 18:36:45]

Xi can you please take a look?

[Xi Han, 2017-05-15 19:00:09]

It is worthy mentioning in the bug description that it is possible particular
for ShortcutSource.EXTERNAL_INTENT.

lgtm

[pkotwicz, 2017-05-16 15:29:20]

Description was changed from

==========
Constrain ShortcutSource to valid values

When Chrome requests a WebAPK install, the WebAPK server uses the newest
available "WebAPK template". This means that if an old Chrome version
installs a WebAPK, it may have installed a WebAPK which sends
ShortcutSource values that the Chrome version does not support

This CL constrains the value of the ShortcutSource in the WebappLauncherActivity
launch intent to a valid value.

BUG=711147
==========

to

==========
Constrain ShortcutSource to valid values

When Chrome requests a WebAPK install, the WebAPK server uses the newest
available "WebAPK template". This means that if an old Chrome version
installs a WebAPK, it may have installed a WebAPK which sends
ShortcutSource values that the Chrome version does not support

This CL constrains the value of the ShortcutSource in the WebappLauncherActivity
launch intent to a valid value.

For instance, m58 Chrome does not know about ShortcutSource#EXTERNAL_INTENT
but the user might install a WebAPK which sends
source==ShortcutSource#EXTERNAL_INTENT to Chrome

BUG=711147
==========

[pkotwicz, 2017-05-16 15:29:36]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2017-05-16 15:29:47]

I have updated the comment. Yaron, for OWNERS

[pkotwicz, 2017-05-17 21:56:26]

Yaron 🔔

[Yaron, 2017-05-17 22:55:22]

On 2017/05/17 21:56:26, pkotwicz wrote:
> Yaron 🔔

err, that empty message was supposed to be lgtm

[pkotwicz, 2017-05-18 01:35:23]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:37:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:27:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495071323488980,
"parent_rev": "0b887ae3437c4d020d2d669b64160820de4023ce", "commit_rev":
"257ccdb4fa9b6a50d24f0f736402874dab49a5d2"}

[commit-bot: I haz the power, 2017-05-18 03:27:34]

Description was changed from

==========
Constrain ShortcutSource to valid values

When Chrome requests a WebAPK install, the WebAPK server uses the newest
available "WebAPK template". This means that if an old Chrome version
installs a WebAPK, it may have installed a WebAPK which sends
ShortcutSource values that the Chrome version does not support

This CL constrains the value of the ShortcutSource in the WebappLauncherActivity
launch intent to a valid value.

For instance, m58 Chrome does not know about ShortcutSource#EXTERNAL_INTENT
but the user might install a WebAPK which sends
source==ShortcutSource#EXTERNAL_INTENT to Chrome

BUG=711147
==========

to

==========
Constrain ShortcutSource to valid values

When Chrome requests a WebAPK install, the WebAPK server uses the newest
available "WebAPK template". This means that if an old Chrome version
installs a WebAPK, it may have installed a WebAPK which sends
ShortcutSource values that the Chrome version does not support

This CL constrains the value of the ShortcutSource in the WebappLauncherActivity
launch intent to a valid value.

For instance, m58 Chrome does not know about ShortcutSource#EXTERNAL_INTENT
but the user might install a WebAPK which sends
source==ShortcutSource#EXTERNAL_INTENT to Chrome

BUG=711147

Review-Url: https://codereview.chromium.org/2880413002
Cr-Commit-Position: refs/heads/master@{#472632}
Committed:
https://chromium.googlesource.com/chromium/src/+/257ccdb4fa9b6a50d24f0f736402...
==========

[commit-bot: I haz the power, 2017-05-18 03:27:38]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/257ccdb4fa9b6a50d24f0f736402...