Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java

Issue 2880413002: Constrain ShortcutSource to valid values (Closed)
Patch Set: Merge branch 'master' into webapk_source Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
index 949ece8ca28bf62dd7d23eed66bed2d6ddd097af..145258971a6b4a56e950c719fa5423b82dc4fa57 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
@@ -76,8 +76,12 @@ public class WebappInfo {
}
protected static int sourceFromIntent(Intent intent) {
- return IntentUtils.safeGetIntExtra(
+ int source = IntentUtils.safeGetIntExtra(
intent, ShortcutHelper.EXTRA_SOURCE, ShortcutSource.UNKNOWN);
+ if (source >= ShortcutSource.COUNT) {
+ source = ShortcutSource.UNKNOWN;
+ }
+ return source;
}
private static String titleFromIntent(Intent intent) {
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698