Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2880373003: Revert of force non-overlay scrollbars in all platform in flamechart (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
bokan, chaopeng, dgozman, caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of force non-overlay scrollbars in all platform in flamechart (patchset #2 id:20001 of https://codereview.chromium.org/2524783002/ ) Reason for revert: The patch made scrollbars inconsistent on Linux. See the comment #10 in crbug.com/667455 Original issue's description: > force non-overlay scrollbars in all platform in flamechart > > Since overlay Scrollbar will make the v-scrollbar disappear in > DevTools/Timeline. In this patch we modify the DevTools/Timeline > v-scrollbar to custom scrollbar the same as what we did in MacOS. > > BUG=667455 > > Review-Url: https://codereview.chromium.org/2524783002 > Cr-Commit-Position: refs/heads/master@{#471615} > Committed: https://chromium.googlesource.com/chromium/src/+/e3bf5300114f14aedbe82f3ece0d142408ac7db7 TBR=bokan@chromium.org,caseq@chromium.org,dgozman@chromium.org,chaopeng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=667455 Review-Url: https://codereview.chromium.org/2880373003 Cr-Commit-Position: refs/heads/master@{#471862} Committed: https://chromium.googlesource.com/chromium/src/+/463ea7fadc00a36b3a83860c64c0aa4fe0338d0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/flameChart.css View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Revert of force non-overlay scrollbars in all platform in flamechart
3 years, 7 months ago (2017-05-15 17:49:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880373003/1
3 years, 7 months ago (2017-05-15 17:50:53 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 19:30:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/463ea7fadc00a36b3a83860c64c0...

Powered by Google App Engine
This is Rietveld 408576698