Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2524783002:
force non-overlay scrollbars in all platform in flamechart (Closed)
|
Created:
4 years, 1 month ago by chaopeng Modified:
3 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionforce non-overlay scrollbars in all platform in flamechart
Since overlay Scrollbar will make the v-scrollbar disappear in
DevTools/Timeline. In this patch we modify the DevTools/Timeline
v-scrollbar to custom scrollbar the same as what we did in MacOS.
BUG=667455
Review-Url: https://codereview.chromium.org/2524783002
Cr-Commit-Position: refs/heads/master@{#471615}
Committed: https://chromium.googlesource.com/chromium/src/+/e3bf5300114f14aedbe82f3ece0d142408ac7db7
Patch Set 1 #Patch Set 2 : update #Messages
Total messages: 18 (8 generated)
Description was changed from ========== force non-overlay scrollbars in all platform in flamechart Since MD Scrollbar will make the v-scrollbar disappear in DevTools/Timeline. In this patch we modify the DevTools/Timeline v-scrollbar to custom scrollbar the same as what we did in MacOS. BUG=667455 ========== to ========== force non-overlay scrollbars in all platform in flamechart Since MD Scrollbar will make the v-scrollbar disappear in DevTools/Timeline. In this patch we modify the DevTools/Timeline v-scrollbar to custom scrollbar the same as what we did in MacOS. BUG=667455 ==========
chaopeng@chromium.org changed reviewers: + bokan@chromium.org
FYI, I don't think we want to do this. At least not like this. The non-overlay scrollbars that exist are modeled to look like the native (Currently Mac) scrollbar. We'd need to do that for each platform.
On 2016/11/22 17:31:25, bokan wrote: > FYI, I don't think we want to do this. At least not like this. The non-overlay > scrollbars that exist are modeled to look like the native (Currently Mac) > scrollbar. We'd need to do that for each platform. bokan@ this is the overlay scrollbar fix for devtools/flamechart
Description was changed from ========== force non-overlay scrollbars in all platform in flamechart Since MD Scrollbar will make the v-scrollbar disappear in DevTools/Timeline. In this patch we modify the DevTools/Timeline v-scrollbar to custom scrollbar the same as what we did in MacOS. BUG=667455 ========== to ========== force non-overlay scrollbars in all platform in flamechart Since overlay Scrollbar will make the v-scrollbar disappear in DevTools/Timeline. In this patch we modify the DevTools/Timeline v-scrollbar to custom scrollbar the same as what we did in MacOS. BUG=667455 ==========
Updated, PTAL.
bokan@chromium.org changed reviewers: + dgozman@chromium.org
Hi Dmitry, Does this change look ok? The flamechart doesn't work well with overlay scrollbars - on Mac we force a custom scrollbar. We're making CrOS use overlays too. Rather than another exception, perhaps it'd be simplest to just do the same thing on all platforms, WDYT? If it's not you, please add an appropriate reviewer, thanks.
dgozman@chromium.org changed reviewers: + caseq@chromium.org
Over to caseq.
lgtm
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494724438512390,
"parent_rev": "9e8f0ba45fae2fc375cac9e6eb0fef94182d466c", "commit_rev":
"e3bf5300114f14aedbe82f3ece0d142408ac7db7"}
Message was sent while issue was closed.
Description was changed from ========== force non-overlay scrollbars in all platform in flamechart Since overlay Scrollbar will make the v-scrollbar disappear in DevTools/Timeline. In this patch we modify the DevTools/Timeline v-scrollbar to custom scrollbar the same as what we did in MacOS. BUG=667455 ========== to ========== force non-overlay scrollbars in all platform in flamechart Since overlay Scrollbar will make the v-scrollbar disappear in DevTools/Timeline. In this patch we modify the DevTools/Timeline v-scrollbar to custom scrollbar the same as what we did in MacOS. BUG=667455 Review-Url: https://codereview.chromium.org/2524783002 Cr-Commit-Position: refs/heads/master@{#471615} Committed: https://chromium.googlesource.com/chromium/src/+/e3bf5300114f14aedbe82f3ece0d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e3bf5300114f14aedbe82f3ece0d...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2880373003/ by alph@chromium.org. The reason for reverting is: The patch made scrollbars inconsistent on Linux. See the comment #10 in crbug.com/667455. |
