Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 288033006: Revert a series of wrong fixes for crbug.com/361011 (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
Reviewers:
CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-html_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Revert a series of wrong fixes for crbug.com/361011 Revert "Elaborate error handling on ScriptLoader::finishLoading()" > Elaborate error handling on ScriptLoader::finishLoading() > > This is a follow up for r170702, which considered only about > dynamically added <script>. This change covers parser-added <script>. > > TEST=adopt-node-crash.html > BUG=365229, 364770 > R=esprehn@chromium.org, eseidel@chromium.org > > Review URL: https://codereview.chromium.org/248013002 > > git-svn-id: svn://svn.chromium.org/blink/trunk@172804 bbb929c8-8fbe-4397-9dbb-9b2b20218538 Revert "Handle didMoveToNewDocument() for <script>" > Handle didMoveToNewDocument() for <script> > > This change handles inter-document move for <script> > so that it cancel script execution when it moves between documents. > As the execution relies on ScriptRunner that is owned by Document, > this cancellation is reasoable if not ideal. > > TEST=append-child-adopt-node-crash.html > BUG=361011 > R=dglazkov@chromium.org, eseidel@chromium.org > > Review URL: https://codereview.chromium.org/229753004 > > git-svn-id: svn://svn.chromium.org/blink/trunk@171160 bbb929c8-8fbe-4397-9dbb-9b2b20218538 BUG=365529, 364770, 361011, 368551 TBR=eseidel@chromium.org, japhet@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -146 lines) Patch
D LayoutTests/fast/dom/HTMLScriptElement/adopt-node-crash.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/adopt-node-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.svg View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-frame.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-frame.svg View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/resources/do-nothing.js View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/resources/should-not-run.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.h View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 2 chunks +14 lines, -32 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-15 09:17:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/288033006/1
6 years, 7 months ago (2014-05-15 09:18:00 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 10:57:52 UTC) #3
Message was sent while issue was closed.
Change committed as 174075

Powered by Google App Engine
This is Rietveld 408576698