Elaborate error handling on ScriptLoader::finishLoading()

Elaborate error handling on ScriptLoader::finishLoading()

This is a follow up for r170702, which considered only about
dynamically added <script>. This change covers parser-added <script>.

TEST=adopt-node-crash.html
BUG=365229, 364770
R=esprehn@chromium.org, eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172804

[Hajime Morrita, 2014-04-22 19:39:34]

PTAL? This is a fix against fuzzer-found bug and
also tries to fix real world bug that is crbug.com/364770

[Hajime Morrita, 2014-04-22 22:09:27]

On 2014/04/22 19:39:34, morrita1 wrote:
> PTAL? This is a fix against fuzzer-found bug and
> also tries to fix real world bug that is crbug.com/364770

ping @esprehn?
As you reviewed
https://src.chromium.org/viewvc/blink?view=revision&revision=170702, I'd like
you to review this as well.

[Hajime Morrita, 2014-04-28 17:56:42]

Hey Elliott, could you take a look? Bots turned into (almost) green so it's
ready to review.

[esprehn, 2014-04-28 18:18:44]

lgtm

https://codereview.chromium.org/248013002/diff/20001/LayoutTests/fast/dom/HTM...
File LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html
(right):

https://codereview.chromium.org/248013002/diff/20001/LayoutTests/fast/dom/HTM...
LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html:2:
<script src=no-nothing.html></script>
do-nothing.js? You have that file, but it seems you're using an html file that
doesn't exist here.

https://codereview.chromium.org/248013002/diff/20001/LayoutTests/fast/dom/HTM...
LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html:7:
</html>
Remove </html> unless you need it.

[Hajime Morrita, 2014-04-28 18:52:52]

Thanks for the review! Landing.

https://codereview.chromium.org/248013002/diff/20001/LayoutTests/fast/dom/HTM...
File LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html
(right):

https://codereview.chromium.org/248013002/diff/20001/LayoutTests/fast/dom/HTM...
LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html:2:
<script src=no-nothing.html></script>
On 2014/04/28 18:18:45, esprehn wrote:
> do-nothing.js? You have that file, but it seems you're using an html file that
> doesn't exist here.
Oops :-( Done.

https://codereview.chromium.org/248013002/diff/20001/LayoutTests/fast/dom/HTM...
LayoutTests/fast/dom/HTMLScriptElement/resources/adopt-node-frame.html:7:
</html>
On 2014/04/28 18:18:45, esprehn wrote:
> Remove </html> unless you need it.

Done.

[Hajime Morrita, 2014-04-28 18:53:58]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:54:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/248013002/40001

[commit-bot: I haz the power, 2014-04-28 19:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 19:36:55]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[gmorrita, 2014-04-28 19:57:14]

The CQ bit was checked by morrita@google.com

[gmorrita, 2014-04-28 19:57:23]

The CQ bit was unchecked by morrita@google.com

[Hajime Morrita, 2014-04-28 19:58:50]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:00:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/248013002/40001

[commit-bot: I haz the power, 2014-04-28 20:55:13]

Change committed as 172804