Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 229753004: Handle didMoveToNewDocument() for <script> (Closed)

Created:
6 years, 8 months ago by Hajime Morrita
Modified:
6 years, 8 months ago
Reviewers:
esprehn, dglazkov, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, sof, eae+blinkwatch, fs, dglazkov+blink, f(malita), adamk+blink_chromium.org, gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Handle didMoveToNewDocument() for <script> This change handles inter-document move for <script> so that it cancel script execution when it moves between documents. As the execution relies on ScriptRunner that is owned by Document, this cancellation is reasoable if not ideal. TEST=append-child-adopt-node-crash.html BUG=361011 R=dglazkov@chromium.org, eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -7 lines) Patch
A LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-frame.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-frame.svg View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLScriptElement/resources/should-not-run.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ScriptLoader.h View 3 chunks +9 lines, -0 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 2 chunks +21 lines, -7 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hajime Morrita
PTAL? A crash fix not related to imports.
6 years, 8 months ago (2014-04-09 01:00:09 UTC) #1
Hajime Morrita
Ping? An usual crash fix.
6 years, 8 months ago (2014-04-09 16:55:48 UTC) #2
dglazkov
lgtm
6 years, 8 months ago (2014-04-09 17:02:06 UTC) #3
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-09 17:03:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/229753004/1
6 years, 8 months ago (2014-04-09 17:03:20 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 18:51:54 UTC) #6
Message was sent while issue was closed.
Change committed as 171160

Powered by Google App Engine
This is Rietveld 408576698