Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2880273002:
Remove Range::TextQuads() and instead use ComputeTextQuads. (Closed)
DescriptionRemove Range::TextQuads() and instead use ComputeTextQuads.
This patch removed the Range::TextQuads function, and uses ComputeTextQuads
instead for its call sites.
ComputeTextQuads was introduced to take EphemeralRange as input
parameter.
BUG=691198
Review-Url: https://codereview.chromium.org/2880273002
Cr-Commit-Position: refs/heads/master@{#473215}
Committed: https://chromium.googlesource.com/chromium/src/+/69a72cbed48edfe7073bd697b71e007eb72bd0d9
Patch Set 1 #
Messages
Total messages: 35 (18 generated)
Description was changed from ========== Remove Range::TextQuads() and instead use ComputeTextQuads. This patch removed the Range::TextQuads function, and uses ComputeTextQuads instead for its callSites. ComputeTextQuads was introduced to take EphemeralRange as input parameter. BUG=691198 ========== to ========== Remove Range::TextQuads() and instead use ComputeTextQuads. This patch removed the Range::TextQuads function, and uses ComputeTextQuads instead for its callSites. ComputeTextQuads was introduced to take EphemeralRange as input parameter. BUG=691198 ==========
tanvir.rizvi@samsung.com changed reviewers: + shanmuga.m@samsung.com, srirama.m@samsung.com
peer review is fine
Description was changed from ========== Remove Range::TextQuads() and instead use ComputeTextQuads. This patch removed the Range::TextQuads function, and uses ComputeTextQuads instead for its callSites. ComputeTextQuads was introduced to take EphemeralRange as input parameter. BUG=691198 ========== to ========== Remove Range::TextQuads() and instead use ComputeTextQuads. This patch removed the Range::TextQuads function, and uses ComputeTextQuads instead for its call sites. ComputeTextQuads was introduced to take EphemeralRange as input parameter. BUG=691198 ==========
tanvir.rizvi@samsung.com changed reviewers: + xiaochengh@chromium.org, yosin@chromium.org
PTAL!!! Thanks
lgtm
yosin@chromium.org changed reviewers: + tkent@chromium.org
lgtm +tkent@ for OWNERS review.
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495197250640190, "parent_rev":
"84fb9e0a3e168b81e538a5ff8ce79e3690396a10", "commit_rev":
"69a72cbed48edfe7073bd697b71e007eb72bd0d9"}
Message was sent while issue was closed.
Description was changed from ========== Remove Range::TextQuads() and instead use ComputeTextQuads. This patch removed the Range::TextQuads function, and uses ComputeTextQuads instead for its call sites. ComputeTextQuads was introduced to take EphemeralRange as input parameter. BUG=691198 ========== to ========== Remove Range::TextQuads() and instead use ComputeTextQuads. This patch removed the Range::TextQuads function, and uses ComputeTextQuads instead for its call sites. ComputeTextQuads was introduced to take EphemeralRange as input parameter. BUG=691198 Review-Url: https://codereview.chromium.org/2880273002 Cr-Commit-Position: refs/heads/master@{#473215} Committed: https://chromium.googlesource.com/chromium/src/+/69a72cbed48edfe7073bd697b71e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/69a72cbed48edfe7073bd697b71e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
