third_party/WebKit/Source/core/dom/RangeTest.cpp - Issue 2880273002: Remove Range::TextQuads() and instead use ComputeTextQuads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/RangeTest.cpp

Issue 2880273002: Remove Range::TextQuads() and instead use ComputeTextQuads. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/RangeTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/RangeTest.cpp b/third_party/WebKit/Source/core/dom/RangeTest.cpp

index bec09849d920cfbcd5a299846b7e4b57a4b8a39d..fbca336ea04424bd7f8cbd35ae842f9cbe2f3708 100644

--- a/third_party/WebKit/Source/core/dom/RangeTest.cpp

+++ b/third_party/WebKit/Source/core/dom/RangeTest.cpp

@@ -10,6 +10,7 @@

#include "core/dom/NodeList.h"

#include "core/dom/Text.h"

#include "core/editing/EditingTestBase.h"

+#include "core/editing/VisibleUnits.h"

#include "core/frame/Settings.h"

#include "core/html/HTMLBodyElement.h"

#include "core/html/HTMLDivElement.h"

@@ -250,7 +251,7 @@ TEST_F(RangeTest, MultipleTextQuads) {

Position end(GetDocument().getElementById("two")->firstChild(), 3);

Range* range = Range::Create(GetDocument(), start, end);

Vector<FloatQuad> quads;

- range->TextQuads(quads);

+ quads.AppendVector(ComputeTextQuads(EphemeralRange(range)));

EXPECT_EQ(2u, quads.size());

}