Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2880253003: Fix main intent metrics when zero tabs present. (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix main intent metrics when zero tabs present. The previous ignore logic was incorrect as it was both calling create and set index. Thus the zero tabs case was resulting in switch tabs always. Adds tests to catch regressions going forward. BUG=717062 Review-Url: https://codereview.chromium.org/2850163002 Cr-Original-Commit-Position: refs/heads/master@{#468493} Review-Url: https://codereview.chromium.org/2880253003 . Cr-Commit-Position: refs/branch-heads/3071@{#565} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetrics.java View 8 chunks +41 lines, -25 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetricsIntegrationTest.java View 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 7 months ago (2017-05-15 20:26:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe.

Powered by Google App Engine
This is Rietveld 408576698