Fix main intent metrics when zero tabs present.

Fix main intent metrics when zero tabs present.

The previous ignore logic was incorrect as it was both calling
create and set index.  Thus the zero tabs case was resulting in
switch tabs always.

Adds tests to catch regressions going forward.

BUG=717062
Review-Url: https://codereview.chromium.org/2850163002
Cr-Commit-Position: refs/heads/master@{#468493}
Committed: https://chromium.googlesource.com/chromium/src/+/7fb9cb4281ac50effd7bdb628e6737fb2d518c4e

[Ted C, 2017-05-01 16:32:21]

tedchoc@chromium.org changed reviewers:
+ twellington@chromium.org

[Ted C, 2017-05-01 16:32:21]

PTAL

[Theresa, 2017-05-01 17:06:50]

lgtm

[Ted C, 2017-05-01 17:10:33]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-05-01 17:11:09]

The CQ bit was unchecked by tedchoc@chromium.org

[Ted C, 2017-05-01 17:11:23]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-05-01 17:11:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2850163002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-01 17:11:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:54:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Ted C, 2017-05-01 21:39:24]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-05-01 21:39:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2850163002/#ps40001
(title: "Add findbugs suppression in code only used for testing")

[commit-bot: I haz the power, 2017-05-01 21:40:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 23:49:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493674764478120,
"parent_rev": "8408b137e5dcdf9382350a20faab00ef441e7080", "commit_rev":
"7fb9cb4281ac50effd7bdb628e6737fb2d518c4e"}

[commit-bot: I haz the power, 2017-05-01 23:49:41]

Description was changed from

==========
Fix main intent metrics when zero tabs present.

The previous ignore logic was incorrect as it was both calling
create and set index.  Thus the zero tabs case was resulting in
switch tabs always.

Adds tests to catch regressions going forward.

BUG=717062
==========

to

==========
Fix main intent metrics when zero tabs present.

The previous ignore logic was incorrect as it was both calling
create and set index.  Thus the zero tabs case was resulting in
switch tabs always.

Adds tests to catch regressions going forward.

BUG=717062

Review-Url: https://codereview.chromium.org/2850163002
Cr-Commit-Position: refs/heads/master@{#468493}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb9cb4281ac50effd7bdb628e67...
==========

[commit-bot: I haz the power, 2017-05-01 23:49:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7fb9cb4281ac50effd7bdb628e67...