Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2880213002: Reduce use of relativize and unsort methods. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, scheglov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix warning and ensure only one AST node is created. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart View 1 2 chunks +4 lines, -5 lines 2 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 1 6 chunks +30 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
ahe
3 years, 7 months ago (2017-05-15 09:02:41 UTC) #2
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-15 10:14:00 UTC) #3
ahe
Uploaded new patch set, found some issues during testing. PTAL
3 years, 7 months ago (2017-05-15 11:34:02 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/2880213002/diff/20001/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart File pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart (right): https://codereview.chromium.org/2880213002/diff/20001/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart#newcode45 pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart:45: DartType buildThisType(LibraryBuilder library) => thisType = target.type; `thisType ...
3 years, 7 months ago (2017-05-15 11:43:56 UTC) #5
ahe
Thank you, Johnni! https://codereview.chromium.org/2880213002/diff/20001/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart File pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart (right): https://codereview.chromium.org/2880213002/diff/20001/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart#newcode45 pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart:45: DartType buildThisType(LibraryBuilder library) => thisType = ...
3 years, 7 months ago (2017-05-15 11:54:30 UTC) #6
ahe
3 years, 7 months ago (2017-05-15 11:56:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d256128d7ca209a182f529e53d5e239644a14dbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698