Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart

Issue 2880213002: Reduce use of relativize and unsort methods. (Closed)
Patch Set: Fix warning and ensure only one AST node is created. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart b/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
index 07c66c998ab83f35e30e561acb445f124789bba8..929b1690b253646bdbbc9fbf6b8ce2371898de9b 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
@@ -18,10 +18,9 @@ import '../kernel/kernel_builder.dart'
import 'dill_library_builder.dart' show DillLibraryBuilder;
class DillFunctionTypeAliasBuilder extends KernelFunctionTypeAliasBuilder {
- final Typedef typedef;
-
- DillFunctionTypeAliasBuilder(this.typedef, DillLibraryBuilder parent)
- : super(null, null, typedef.name, null, null, parent, typedef.fileOffset);
+ DillFunctionTypeAliasBuilder(Typedef typedef, DillLibraryBuilder parent)
+ : super(null, null, typedef.name, null, null, parent, typedef.fileOffset,
+ typedef);
@override
List<FormalParameterBuilder> get formals {
@@ -43,5 +42,5 @@ class DillFunctionTypeAliasBuilder extends KernelFunctionTypeAliasBuilder {
}
@override
- DartType buildThisType(LibraryBuilder library) => typedef.type;
+ DartType buildThisType(LibraryBuilder library) => thisType = target.type;
Johnni Winther 2017/05/15 11:43:56 `thisType = ...` -> `thisType ??= ...`
ahe 2017/05/15 11:54:29 Done.
}
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698