Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2882173002: Add comment about metadata syntax problem in static methods. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add comment about metadata syntax problem in static methods. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/5e040f1abf60fbbc8e410852f65a937bc7b2f59e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M docs/language/dartLangSpec.tex View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
ahe
3 years, 7 months ago (2017-05-15 09:01:45 UTC) #3
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-15 10:13:22 UTC) #4
ahe
Committed patchset #1 (id:20001) manually as 5e040f1abf60fbbc8e410852f65a937bc7b2f59e (presubmit successful).
3 years, 7 months ago (2017-05-15 11:55:13 UTC) #6
Lasse Reichstein Nielsen
Erik, did you work on making this correct?
3 years, 7 months ago (2017-05-15 12:12:40 UTC) #8
eernst
3 years, 7 months ago (2017-05-15 12:48:39 UTC) #9
Message was sent while issue was closed.
On 2017/05/15 12:12:40, Lasse Reichstein Nielsen wrote:
> Erik, did you work on making this correct?

Yes, the spec parser (https://codereview.chromium.org/2688903004)
includes changes to the grammar addressing this issue.

Powered by Google App Engine
This is Rietveld 408576698