Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2880083002: chromeos: Remove LibCrosService's ResolveNetworkProxy method (Closed)

Created:
3 years, 7 months ago by Daniel Erat
Modified:
3 years, 6 months ago
Reviewers:
teravest
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove LibCrosService's ResolveNetworkProxy method Remove the ResolveNetworkProxy D-Bus method exported by org.chromium.LibCrosService, along with support for requesting that the response be sent via a signal (as opposed to an async method call). This method has been renamed to ResolveProxy and lives in a new org.chromium.NetworkProxyService service. All Chrome OS callers (tlsdated, crash-reporter, update_engine) have been updated to use the new service. BUG=446115, 703217 Review-Url: https://codereview.chromium.org/2880083002 Cr-Commit-Position: refs/heads/master@{#479509} Committed: https://chromium.googlesource.com/chromium/src/+/67fdc5416dcf8317fe5b43f6afd999100e540c9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -257 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider.h View 4 chunks +10 lines, -26 lines 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider.cc View 7 chunks +9 lines, -73 lines 0 comments Download
M chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc View 7 chunks +10 lines, -150 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Daniel Erat
This needs to wait until the 22nd or so to go in so that Chrome ...
3 years, 7 months ago (2017-05-13 15:41:07 UTC) #4
teravest
lgtm May as well add 446115 to the BUG line in the description too.
3 years, 7 months ago (2017-05-15 14:12:54 UTC) #7
Daniel Erat
On 2017/05/15 14:12:54, teravest wrote: > lgtm > > May as well add 446115 to ...
3 years, 7 months ago (2017-05-15 14:15:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880083002/1
3 years, 6 months ago (2017-06-14 21:29:57 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 21:35:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67fdc5416dcf8317fe5b43f6afd9...

Powered by Google App Engine
This is Rietveld 408576698