Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 2880083002: chromeos: Remove LibCrosService's ResolveNetworkProxy method (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromeos/dbus/services/proxy_resolution_service_provider.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/chrome_browser_main_chromeos.h" 5 #include "chrome/browser/chromeos/chrome_browser_main_chromeos.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 DBusThreadManager::Initialize(process_mask); 270 DBusThreadManager::Initialize(process_mask);
271 271
272 bluez::BluezDBusManager::Initialize( 272 bluez::BluezDBusManager::Initialize(
273 DBusThreadManager::Get()->GetSystemBus(), 273 DBusThreadManager::Get()->GetSystemBus(),
274 chromeos::DBusThreadManager::Get()->IsUsingFakes()); 274 chromeos::DBusThreadManager::Get()->IsUsingFakes());
275 275
276 PowerPolicyController::Initialize( 276 PowerPolicyController::Initialize(
277 DBusThreadManager::Get()->GetPowerManagerClient()); 277 DBusThreadManager::Get()->GetPowerManagerClient());
278 278
279 CrosDBusService::ServiceProviderList service_providers; 279 CrosDBusService::ServiceProviderList service_providers;
280 // TODO(derat): Remove this provider once all callers are using
281 // |proxy_resolution_service_| instead: http://crbug.com/703217
282 service_providers.push_back(
283 base::MakeUnique<ProxyResolutionServiceProvider>(
284 kLibCrosServiceInterface, kResolveNetworkProxy,
285 base::MakeUnique<ChromeProxyResolutionServiceProviderDelegate>()));
286 if (GetAshConfig() == ash::Config::CLASSIC) { 280 if (GetAshConfig() == ash::Config::CLASSIC) {
287 // TODO(crbug.com/629707): revisit this with mustash dbus work. 281 // TODO(crbug.com/629707): revisit this with mustash dbus work.
288 service_providers.push_back(base::MakeUnique<DisplayPowerServiceProvider>( 282 service_providers.push_back(base::MakeUnique<DisplayPowerServiceProvider>(
289 base::MakeUnique<ChromeDisplayPowerServiceProviderDelegate>())); 283 base::MakeUnique<ChromeDisplayPowerServiceProviderDelegate>()));
290 } 284 }
291 service_providers.push_back(base::MakeUnique<LivenessServiceProvider>()); 285 service_providers.push_back(base::MakeUnique<LivenessServiceProvider>());
292 service_providers.push_back(base::MakeUnique<ScreenLockServiceProvider>()); 286 service_providers.push_back(base::MakeUnique<ScreenLockServiceProvider>());
293 // TODO(sky): once mash supports simplified display mode we should always 287 // TODO(sky): once mash supports simplified display mode we should always
294 // use ChromeConsoleServiceProviderDelegate. 288 // use ChromeConsoleServiceProviderDelegate.
295 if (GetAshConfig() != ash::Config::MASH) { 289 if (GetAshConfig() != ash::Config::MASH) {
296 service_providers.push_back(base::MakeUnique<ConsoleServiceProvider>( 290 service_providers.push_back(base::MakeUnique<ConsoleServiceProvider>(
297 base::MakeUnique<ChromeConsoleServiceProviderDelegate>())); 291 base::MakeUnique<ChromeConsoleServiceProviderDelegate>()));
298 } else { 292 } else {
299 service_providers.push_back(base::MakeUnique<ConsoleServiceProvider>( 293 service_providers.push_back(base::MakeUnique<ConsoleServiceProvider>(
300 base::MakeUnique<MusConsoleServiceProviderDelegate>())); 294 base::MakeUnique<MusConsoleServiceProviderDelegate>()));
301 } 295 }
302 // TODO(teravest): Remove this provider once all callers are using 296 // TODO(teravest): Remove this provider once all callers are using
303 // |kiosk_info_service_| instead: http://crbug.com/703229 297 // |kiosk_info_service_| instead: http://crbug.com/703229
304 service_providers.push_back(base::MakeUnique<KioskInfoService>( 298 service_providers.push_back(base::MakeUnique<KioskInfoService>(
305 kLibCrosServiceInterface, 299 kLibCrosServiceInterface,
306 kKioskAppServiceGetRequiredPlatformVersionMethod)); 300 kKioskAppServiceGetRequiredPlatformVersionMethod));
307 cros_dbus_service_ = CrosDBusService::Create( 301 cros_dbus_service_ = CrosDBusService::Create(
308 kLibCrosServiceName, dbus::ObjectPath(kLibCrosServicePath), 302 kLibCrosServiceName, dbus::ObjectPath(kLibCrosServicePath),
309 std::move(service_providers)); 303 std::move(service_providers));
310 304
311 proxy_resolution_service_ = CrosDBusService::Create( 305 proxy_resolution_service_ = CrosDBusService::Create(
312 kNetworkProxyServiceName, dbus::ObjectPath(kNetworkProxyServicePath), 306 kNetworkProxyServiceName, dbus::ObjectPath(kNetworkProxyServicePath),
313 CrosDBusService::CreateServiceProviderList( 307 CrosDBusService::CreateServiceProviderList(
314 base::MakeUnique<ProxyResolutionServiceProvider>( 308 base::MakeUnique<ProxyResolutionServiceProvider>(
315 kNetworkProxyServiceInterface,
316 kNetworkProxyServiceResolveProxyMethod,
317 base::MakeUnique< 309 base::MakeUnique<
318 ChromeProxyResolutionServiceProviderDelegate>()))); 310 ChromeProxyResolutionServiceProviderDelegate>())));
319 311
320 kiosk_info_service_ = CrosDBusService::Create( 312 kiosk_info_service_ = CrosDBusService::Create(
321 kKioskAppServiceName, dbus::ObjectPath(kKioskAppServicePath), 313 kKioskAppServiceName, dbus::ObjectPath(kKioskAppServicePath),
322 CrosDBusService::CreateServiceProviderList( 314 CrosDBusService::CreateServiceProviderList(
323 base::MakeUnique<KioskInfoService>( 315 base::MakeUnique<KioskInfoService>(
324 kKioskAppServiceInterface, 316 kKioskAppServiceInterface,
325 kKioskAppServiceGetRequiredPlatformVersionMethod))); 317 kKioskAppServiceGetRequiredPlatformVersionMethod)));
326 318
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
1092 1084
1093 ChromeBrowserMainPartsLinux::PostDestroyThreads(); 1085 ChromeBrowserMainPartsLinux::PostDestroyThreads();
1094 1086
1095 // Destroy DeviceSettingsService after g_browser_process. 1087 // Destroy DeviceSettingsService after g_browser_process.
1096 DeviceSettingsService::Shutdown(); 1088 DeviceSettingsService::Shutdown();
1097 1089
1098 chromeos::ShutdownCloseTracking(); 1090 chromeos::ShutdownCloseTracking();
1099 } 1091 }
1100 1092
1101 } // namespace chromeos 1093 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chromeos/dbus/services/proxy_resolution_service_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698