Revert of Build FreeType with HarfBuzz support

Revert of Build FreeType with HarfBuzz support (patchset #7 id:110001 of https://codereview.chromium.org/2871133004/ )

Reason for revert:
Speculative revert for possibly fixing Linux builder compile failure which lead to tree closure https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/17727


Original issue's description:
> Build FreeType with HarfBuzz support
> 
> FreeType's autohinter uses HarfBuzz API to collect additional GSUB and
> GPOS mappings to detect ligatures that should be aligned by the
> autohinter. Previously we were not able to build FreeType with HarfBuzz
> support because of the cyclic dependency. This CL resolves the cyclic
> dependency by building a bootstrap FreeType in order to build HarfBuzz'
> hb_ft_* functions as a static library called harfbuzz-ng-ft. Then we
> build harfbuzz-ng separately (which does not depend on FreeType), then
> we build FreeType depending on harfbuzz-ng and harfbuzz-ng-ft.
> 
> This resolves issues with fi and ffi ligatures in Roboto looking like
> they were shifted to a different baseline.
> 
> I tried developing a pixel test for this, which works if I force usage
> of the FreeType autohinter through SkPaint::kSlight_Hinting, however we
> are currently unable to automatically test this since our Linux layout
> tests do not exercise the autohinting code and do not set this hinting
> mode, probably due to the special fontconfig settings that we are using
> for the layout tests. Manually verifying the Roboto ligatures however
> confirms that this works.
> 
> BUG=617168
> 
> Review-Url: https://codereview.chromium.org/2871133004
> Cr-Commit-Position: refs/heads/master@{#471277}
> Committed: https://chromium.googlesource.com/chromium/src/+/a377e3e1fa4f44a58f70abb2402e6cc79e210945

TBR=behdad@chromium.org,dpranke@chromium.org,peter@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617168
Review-Url: https://codereview.chromium.org/2879843003
Cr-Commit-Position: refs/heads/master@{#471298}
Committed: https://chromium.googlesource.com/chromium/src/+/149eb6a66fc6ff7d67627cf8305f833ae50b9b66

[drott, 2017-05-12 14:40:25]

The CQ bit was checked by drott@chromium.org

[drott, 2017-05-12 14:40:25]

Created Revert of Build FreeType with HarfBuzz support

[commit-bot: I haz the power, 2017-05-12 14:40:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 14:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 14:41:21]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:3131
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
fca034542fcdaf4d1206887ef70eaaf1337e1803..9d518367fcea43fcf2d1041e5b12e3b8735b21ef
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -3131,8 +3131,6 @@
 
 crbug.com/667371
inspector/elements/styles-1/color-aware-property-value-edit.html [ Pass Failure
]
 
-crbug.com/617168 [ Linux ] fast/text/shaping/same-script-different-lang.html [
NeedsRebaseline ]
-
 # [css-ui] Imported tests from W3C suite.
 crbug.com/669473 external/wpt/css/css-ui-3/box-sizing-014.html [ Failure ]
 crbug.com/669473 external/wpt/css/css-ui-3/box-sizing-015.html [ Failure ]

[drott, 2017-05-12 14:49:30]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-05-12 14:50:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 14:50:55]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494600570692090,
"parent_rev": "a66d812aa78debb856c1938f439e98feabeaeada", "commit_rev":
"149eb6a66fc6ff7d67627cf8305f833ae50b9b66"}

[commit-bot: I haz the power, 2017-05-12 14:51:17]

Description was changed from

==========
Revert of Build FreeType with HarfBuzz support (patchset #7 id:110001 of
https://codereview.chromium.org/2871133004/ )

Reason for revert:
Speculative revert for possibly fixing Linux builder compile failure which lead
to tree closure
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...


Original issue's description:
> Build FreeType with HarfBuzz support
> 
> FreeType's autohinter uses HarfBuzz API to collect additional GSUB and
> GPOS mappings to detect ligatures that should be aligned by the
> autohinter. Previously we were not able to build FreeType with HarfBuzz
> support because of the cyclic dependency. This CL resolves the cyclic
> dependency by building a bootstrap FreeType in order to build HarfBuzz'
> hb_ft_* functions as a static library called harfbuzz-ng-ft. Then we
> build harfbuzz-ng separately (which does not depend on FreeType), then
> we build FreeType depending on harfbuzz-ng and harfbuzz-ng-ft.
> 
> This resolves issues with fi and ffi ligatures in Roboto looking like
> they were shifted to a different baseline.
> 
> I tried developing a pixel test for this, which works if I force usage
> of the FreeType autohinter through SkPaint::kSlight_Hinting, however we
> are currently unable to automatically test this since our Linux layout
> tests do not exercise the autohinting code and do not set this hinting
> mode, probably due to the special fontconfig settings that we are using
> for the layout tests. Manually verifying the Roboto ligatures however
> confirms that this works.
> 
> BUG=617168
> 
> Review-Url: https://codereview.chromium.org/2871133004
> Cr-Commit-Position: refs/heads/master@{#471277}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a377e3e1fa4f44a58f70abb2402e...

TBR=behdad@chromium.org,dpranke@chromium.org,peter@chromium.org,machenbach@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617168
==========

to

==========
Revert of Build FreeType with HarfBuzz support (patchset #7 id:110001 of
https://codereview.chromium.org/2871133004/ )

Reason for revert:
Speculative revert for possibly fixing Linux builder compile failure which lead
to tree closure
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...


Original issue's description:
> Build FreeType with HarfBuzz support
> 
> FreeType's autohinter uses HarfBuzz API to collect additional GSUB and
> GPOS mappings to detect ligatures that should be aligned by the
> autohinter. Previously we were not able to build FreeType with HarfBuzz
> support because of the cyclic dependency. This CL resolves the cyclic
> dependency by building a bootstrap FreeType in order to build HarfBuzz'
> hb_ft_* functions as a static library called harfbuzz-ng-ft. Then we
> build harfbuzz-ng separately (which does not depend on FreeType), then
> we build FreeType depending on harfbuzz-ng and harfbuzz-ng-ft.
> 
> This resolves issues with fi and ffi ligatures in Roboto looking like
> they were shifted to a different baseline.
> 
> I tried developing a pixel test for this, which works if I force usage
> of the FreeType autohinter through SkPaint::kSlight_Hinting, however we
> are currently unable to automatically test this since our Linux layout
> tests do not exercise the autohinting code and do not set this hinting
> mode, probably due to the special fontconfig settings that we are using
> for the layout tests. Manually verifying the Roboto ligatures however
> confirms that this works.
> 
> BUG=617168
> 
> Review-Url: https://codereview.chromium.org/2871133004
> Cr-Commit-Position: refs/heads/master@{#471277}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a377e3e1fa4f44a58f70abb2402e...

TBR=behdad@chromium.org,dpranke@chromium.org,peter@chromium.org,machenbach@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617168

Review-Url: https://codereview.chromium.org/2879843003
Cr-Commit-Position: refs/heads/master@{#471298}
Committed:
https://chromium.googlesource.com/chromium/src/+/149eb6a66fc6ff7d67627cf8305f...
==========

[commit-bot: I haz the power, 2017-05-12 14:51:18]

Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/149eb6a66fc6ff7d67627cf8305f...