Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: chrome/android/java/res/layout/page_info_permission_row.xml

Issue 2879733002: [subresource_filter] Add a subtitle for Android Page Info (Closed)
Patch Set: make unavailable_message TextViewWithLeading too Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/page_info_permission_row.xml
diff --git a/chrome/android/java/res/layout/page_info_permission_row.xml b/chrome/android/java/res/layout/page_info_permission_row.xml
index 703bd7eb35f9a70c3bd8784f58ddea870bb34bb3..61f9bfc8b87f53d5e3b90eb090b381008b399fd1 100644
--- a/chrome/android/java/res/layout/page_info_permission_row.xml
+++ b/chrome/android/java/res/layout/page_info_permission_row.xml
@@ -3,7 +3,9 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<RelativeLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
android:id="@+id/page_info_permission_row"
android:layout_width="match_parent"
android:layout_height="wrap_content"
@@ -24,14 +26,25 @@
android:textColor="@color/page_info_popup_text"
android:textSize="14sp" />
- <TextView
+ <org.chromium.ui.widget.TextViewWithLeading
android:id="@+id/page_info_permission_unavailable_message"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_below="@id/page_info_permission_status"
android:layout_toEndOf="@id/page_info_permission_icon"
- android:lineSpacingExtra="6dp"
android:textColor="@color/page_info_popup_text_link"
android:textSize="14sp"
- android:visibility="gone" />
+ android:visibility="gone"
+ chrome:leading="20dp" />
+
+ <org.chromium.ui.widget.TextViewWithLeading
+ android:id="@+id/page_info_permission_subtitle"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_below="@id/page_info_permission_status"
+ android:layout_toEndOf="@id/page_info_permission_icon"
+ android:textSize="14sp"
+ android:textColor="@color/secondary_text_default_material_light"
+ android:visibility="gone"
+ chrome:leading="20dp" />
</RelativeLayout>
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698