Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

Issue 2879733002: [subresource_filter] Add a subtitle for Android Page Info (Closed)
Patch Set: make unavailable_message TextViewWithLeading too Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/page_info_permission_row.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
index c44e6f5f28ea0ae296d7ceb0f68e8d713127162d..953715cb5b9df4f612df7313c83e5dc0bcdd929d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
@@ -621,6 +621,14 @@ public class PageInfoPopup implements OnClickListener {
}
}
+ // The subresource filter permission requires an additional static subtitle.
+ if (permission.type == ContentSettingsType.CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER) {
+ TextView permissionUnavailable =
+ (TextView) permissionRow.findViewById(R.id.page_info_permission_subtitle);
+ permissionUnavailable.setVisibility(View.VISIBLE);
+ permissionUnavailable.setText(R.string.subresource_filter_permission_title);
+ }
+
TextView permissionStatus = (TextView) permissionRow.findViewById(
R.id.page_info_permission_status);
SpannableStringBuilder builder = new SpannableStringBuilder();
« no previous file with comments | « chrome/android/java/res/layout/page_info_permission_row.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698