Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/android/java/res/layout/page_info_permission_row.xml

Issue 2879733002: [subresource_filter] Add a subtitle for Android Page Info (Closed)
Patch Set: make unavailable_message TextViewWithLeading too Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" 6 <RelativeLayout
7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
7 android:id="@+id/page_info_permission_row" 9 android:id="@+id/page_info_permission_row"
8 android:layout_width="match_parent" 10 android:layout_width="match_parent"
9 android:layout_height="wrap_content" 11 android:layout_height="wrap_content"
10 android:paddingTop="12dp" > 12 android:paddingTop="12dp" >
11 13
12 <ImageView 14 <ImageView
13 android:id="@+id/page_info_permission_icon" 15 android:id="@+id/page_info_permission_icon"
14 android:layout_width="@dimen/page_info_popup_permission_icon_size" 16 android:layout_width="@dimen/page_info_popup_permission_icon_size"
15 android:layout_height="@dimen/page_info_popup_permission_icon_size" 17 android:layout_height="@dimen/page_info_popup_permission_icon_size"
16 android:layout_marginEnd="16dp" 18 android:layout_marginEnd="16dp"
17 android:contentDescription="@null" /> 19 android:contentDescription="@null" />
18 20
19 <TextView 21 <TextView
20 android:id="@+id/page_info_permission_status" 22 android:id="@+id/page_info_permission_status"
21 android:layout_width="match_parent" 23 android:layout_width="match_parent"
22 android:layout_height="wrap_content" 24 android:layout_height="wrap_content"
23 android:layout_toEndOf="@id/page_info_permission_icon" 25 android:layout_toEndOf="@id/page_info_permission_icon"
24 android:textColor="@color/page_info_popup_text" 26 android:textColor="@color/page_info_popup_text"
25 android:textSize="14sp" /> 27 android:textSize="14sp" />
26 28
27 <TextView 29 <org.chromium.ui.widget.TextViewWithLeading
28 android:id="@+id/page_info_permission_unavailable_message" 30 android:id="@+id/page_info_permission_unavailable_message"
29 android:layout_width="match_parent" 31 android:layout_width="match_parent"
30 android:layout_height="wrap_content" 32 android:layout_height="wrap_content"
31 android:layout_below="@id/page_info_permission_status" 33 android:layout_below="@id/page_info_permission_status"
32 android:layout_toEndOf="@id/page_info_permission_icon" 34 android:layout_toEndOf="@id/page_info_permission_icon"
33 android:lineSpacingExtra="6dp"
34 android:textColor="@color/page_info_popup_text_link" 35 android:textColor="@color/page_info_popup_text_link"
35 android:textSize="14sp" 36 android:textSize="14sp"
36 android:visibility="gone" /> 37 android:visibility="gone"
38 chrome:leading="20dp" />
39
40 <org.chromium.ui.widget.TextViewWithLeading
41 android:id="@+id/page_info_permission_subtitle"
42 android:layout_width="match_parent"
43 android:layout_height="wrap_content"
44 android:layout_below="@id/page_info_permission_status"
45 android:layout_toEndOf="@id/page_info_permission_icon"
46 android:textSize="14sp"
47 android:textColor="@color/secondary_text_default_material_light"
48 android:visibility="gone"
49 chrome:leading="20dp" />
37 </RelativeLayout> 50 </RelativeLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698