Reland "Refined DCHECK preventing multiple event forwarders in VA tree path"

Reland "Refined DCHECK preventing multiple event forwarders in VA tree path"

Previous CL: https://crrev.com/2861413002

The new test in the CL depends on the presence of DCHECK macro
but some buildbots failed since they don't have DCHECK enabled
(Trybot passed because they have deliberately DCHECK on).

Added #if DCHECK_IS_ON() to handle that, and also used a simpler
macro EXPECT_DCHECK_DEATH over DCHECK_DEATH.

> A ViewAndroid tree path from the top to a leaf node can have only
> a single EventForwarder instance. Rewrote helper methods used for
> DCHECK that enforces the requirement to match the actual job with
> the intention.

BUG=717271
Review-Url: https://codereview.chromium.org/2861413002
Cr-Commit-Position: refs/heads/master@{#470814}
Committed: https://chromium.googlesource.com/chromium/src/+/1a116ecfdf829702b653ded84a0e1cdb8bdfd7d6

patch from issue 2861413002 at patchset 200001 (http://crrev.com/2861413002#ps200001)

Review-Url: https://codereview.chromium.org/2879713002
Cr-Commit-Position: refs/heads/master@{#471262}
Committed: https://chromium.googlesource.com/chromium/src/+/e982114658f12e1dd021e74580ef7ccd73c44a85

[Jinsuk Kim, 2017-05-12 00:13:30]

jinsukkim@chromium.org changed reviewers:
+ boliu@chromium.org

[Jinsuk Kim, 2017-05-12 00:13:31]

note: view_android.{cc|h} haven't changed. Only the unit test in enclosed in #if
.. #endif.

[Jinsuk Kim, 2017-05-12 00:39:49]

Patchset #1 (id:1) has been deleted

[boliu, 2017-05-12 01:23:13]

https://codereview.chromium.org/2879713002/diff/40001/ui/android/view_android...
File ui/android/view_android_unittests.cc (right):

https://codereview.chromium.org/2879713002/diff/40001/ui/android/view_android...
ui/android/view_android_unittests.cc:176:
EXPECT_DCHECK_DEATH(parent.AddChild(&child));
I think using EXPECT_DCHECK_DEATH means you don't need to wrap this around
DCHECK_IS_ON?

[Jinsuk Kim, 2017-05-12 01:42:57]

https://codereview.chromium.org/2879713002/diff/40001/ui/android/view_android...
File ui/android/view_android_unittests.cc (right):

https://codereview.chromium.org/2879713002/diff/40001/ui/android/view_android...
ui/android/view_android_unittests.cc:176:
EXPECT_DCHECK_DEATH(parent.AddChild(&child));
On 2017/05/12 01:23:13, boliu wrote:
> I think using EXPECT_DCHECK_DEATH means you don't need to wrap this around
> DCHECK_IS_ON?

I preferred not running this test at all but there's no harm running it without
EXPECT_ in this case. Remove the #if/#endif.

[boliu, 2017-05-12 01:45:46]

lgtm

[Jinsuk Kim, 2017-05-12 09:25:51]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-05-12 09:26:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 09:57:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494581151525210,
"parent_rev": "2cc4ba79f53e6d0073d51343cbbbc4f1f5739952", "commit_rev":
"e982114658f12e1dd021e74580ef7ccd73c44a85"}

[commit-bot: I haz the power, 2017-05-12 09:57:19]

Description was changed from

==========
Reland "Refined DCHECK preventing multiple event forwarders in VA tree path"

Previous CL: https://crrev.com/2861413002

The new test in the CL depends on the presence of DCHECK macro
but some buildbots failed since they don't have DCHECK enabled
(Trybot passed because they have deliberately DCHECK on).

Added #if DCHECK_IS_ON() to handle that, and also used a simpler
macro EXPECT_DCHECK_DEATH over DCHECK_DEATH.

> A ViewAndroid tree path from the top to a leaf node can have only
> a single EventForwarder instance. Rewrote helper methods used for
> DCHECK that enforces the requirement to match the actual job with
> the intention.

BUG=717271

Review-Url: https://codereview.chromium.org/2861413002
Cr-Commit-Position: refs/heads/master@{#470814}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a116ecfdf829702b653ded84a0e...

patch from issue 2861413002 at patchset 200001
(http://crrev.com/2861413002#ps200001)
==========

to

==========
Reland "Refined DCHECK preventing multiple event forwarders in VA tree path"

Previous CL: https://crrev.com/2861413002

The new test in the CL depends on the presence of DCHECK macro
but some buildbots failed since they don't have DCHECK enabled
(Trybot passed because they have deliberately DCHECK on).

Added #if DCHECK_IS_ON() to handle that, and also used a simpler
macro EXPECT_DCHECK_DEATH over DCHECK_DEATH.

> A ViewAndroid tree path from the top to a leaf node can have only
> a single EventForwarder instance. Rewrote helper methods used for
> DCHECK that enforces the requirement to match the actual job with
> the intention.

BUG=717271

Review-Url: https://codereview.chromium.org/2861413002
Cr-Commit-Position: refs/heads/master@{#470814}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a116ecfdf829702b653ded84a0e...

patch from issue 2861413002 at patchset 200001
(http://crrev.com/2861413002#ps200001)

Review-Url: https://codereview.chromium.org/2879713002
Cr-Commit-Position: refs/heads/master@{#471262}
Committed:
https://chromium.googlesource.com/chromium/src/+/e982114658f12e1dd021e74580ef...
==========

[commit-bot: I haz the power, 2017-05-12 09:57:20]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e982114658f12e1dd021e74580ef...