Reland "Refined DCHECK preventing multiple event forwarders in VA tree path"

ui/android/view_android_unittests.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/test/gtest_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/android/event_forwarder.h"
 #include "ui/android/view_android.h"
 #include "ui/android/view_client.h"
 #include "ui/events/android/motion_event_android.h"
 
 namespace ui {
 
 using base::android::JavaParamRef;
 
@@ skipping 144 matching lines @@
   client1_.SetHandleEvent(false);
   GenerateTouchEventAt(40, 60);
   EXPECT_TRUE(client1_.EventCalled());
   ExpectHit(client2_);
 
   GenerateTouchEventAt(100, 70);
   EXPECT_TRUE(client1_.EventCalled());
   ExpectHit(client3_);
 }
 
+#if DCHECK_IS_ON()
+TEST(ViewAndroidTest, ChecksMultipleEventForwarders) {
+  ViewAndroid parent;
+  ViewAndroid child;
+  parent.GetEventForwarder();
+  child.GetEventForwarder();
+  EXPECT_DCHECK_DEATH(parent.AddChild(&child));

[boliu, 2017/05/12 01:23:13]

I think using EXPECT_DCHECK_DEATH means you don't need to wrap this around
DCHECK_IS_ON?

[Jinsuk Kim, 2017/05/12 01:42:57]

I preferred not running this test at all but there's no harm running it without
EXPECT_ in this case. Remove the #if/#endif.

+
+  ViewAndroid parent2;
+  ViewAndroid child2;
+  parent2.GetEventForwarder();
+  parent2.AddChild(&child2);
+  EXPECT_DCHECK_DEATH(child2.GetEventForwarder());
+
+  ViewAndroid window;
+  ViewAndroid wcv1, wcv2;
+  ViewAndroid rwhv1a, rwhv1b, rwhv2;
+  wcv1.GetEventForwarder();
+  wcv2.GetEventForwarder();
+
+  window.AddChild(&wcv1);
+  wcv1.AddChild(&rwhv1a);
+  wcv1.AddChild(&rwhv1b);
+
+  wcv2.AddChild(&rwhv2);
+
+  // window should be able to add wcv2 since there's only one event forwarder
+  // in the path window - wcv2* - rwvh2
+  window.AddChild(&wcv2);
+
+  // Additional event forwarder will cause failure.
+  EXPECT_DCHECK_DEATH(rwhv2.GetEventForwarder());
+}
+#endif
+
 }  // namespace ui