Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2879123002: Add generated InheritedDataShared in ComputedStyleBase. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add generated InheritedDataShared in ComputedStyleBase. ComputedStyle::InheritedDataShared is a handwritten function that compares subgroup pointers. This makes it difficult to change the group that a field belongs to, as it might break the correctness of the function. This patch adds a generated function InheritedDataShared in ComputedStyleBase that works no matter where fields are stored. There are no behavioural changes in this patch. Diff of generated files: https://gist.github.com/darrnshn/a88dd2eaf35380e4e24d18384fb3c4b4/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2879123002 Cr-Commit-Position: refs/heads/master@{#472593} Committed: https://chromium.googlesource.com/chromium/src/+/1f524da250c870845b077299d2a0ebda85bf90d9

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 32 (28 generated)
shend
Hi Eddy, PTAL (no bots due to dependency) (nainar@ already gave first pass lgtm; this ...
3 years, 7 months ago (2017-05-15 01:01:34 UTC) #10
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-15 04:04:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879123002/80001
3 years, 7 months ago (2017-05-17 22:20:23 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 22:39:05 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1f524da250c870845b077299d2a0...

Powered by Google App Engine
This is Rietveld 408576698